Skip to content

win32: Remove old code for VC++ 6.0 or older#9616

Closed
k-takata wants to merge 1 commit intovim:masterfrom
k-takata:win32-drop-support-for-vc6
Closed

win32: Remove old code for VC++ 6.0 or older#9616
k-takata wants to merge 1 commit intovim:masterfrom
k-takata:win32-drop-support-for-vc6

Conversation

@k-takata
Copy link
Member

There were many #ifdefs for VC6. Make the code cleaner.

There were many #ifdefs for VC6. Make the code cleaner.
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #9616 (d27c980) into master (058ee7c) will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9616      +/-   ##
==========================================
+ Coverage   83.18%   83.51%   +0.33%     
==========================================
  Files         154      154              
  Lines      174516   174516              
  Branches    39260    39260              
==========================================
+ Hits       145163   145746     +583     
+ Misses      17214    16667     -547     
+ Partials    12139    12103      -36     
Flag Coverage Δ
huge-clang-none 81.88% <ø> (-0.01%) ⬇️
huge-gcc-none 82.24% <ø> (+<0.01%) ⬆️
huge-gcc-testgui 80.70% <ø> (?)
huge-gcc-unittests 2.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ex_docmd.c 91.32% <ø> (+0.07%) ⬆️
src/if_cscope.c 76.13% <ø> (ø)
src/if_ruby.c 84.63% <ø> (ø)
src/time.c 88.83% <ø> (+1.36%) ⬆️
src/netbeans.c 71.98% <0.00%> (-0.23%) ⬇️
src/search.c 85.26% <0.00%> (-0.10%) ⬇️
src/ex_getln.c 85.09% <0.00%> (-0.05%) ⬇️
src/main.c 85.05% <0.00%> (+0.07%) ⬆️
src/vim9cmds.c 86.07% <0.00%> (+0.09%) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 058ee7c...d27c980. Read the comment docs.

@k-takata
Copy link
Member Author

Maybe we can also remove the code for VC++ 7.0/7.1 (VS 2002/2003)?

@brammool
Copy link
Contributor

I can include this one first. I think the oldest that still works in VC 2008, or studio 9.0.. Haven't tried it though.
Supporting older versions can be useful in some cases, newer versions tend to drop support for older MS-Windows.

@brammool brammool closed this in c351dc1 Jan 24, 2022
@k-takata k-takata deleted the win32-drop-support-for-vc6 branch January 24, 2022 11:35
@k-takata
Copy link
Member Author

VC 2005 is the last version that supports building for Windows 9x.
VC 2010 is the last version that supports building for Windows XP without adding the /subsystem linker option. Also, this is the last version that doesn't support the C99 style variable declaration.
VC 2013 is the last version before switching to Universal CRT.
VC 2015 is the last version that includes Windows SDK 7.1 that supports building for Windows XP.

VC 2008 and VC 2012 are not so notable, I think.

We use VC 2010 on AppVeyor, so it might be better to make VC 2010 as the oldest support version?

@brammool
Copy link
Contributor

brammool commented Jan 25, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants