Apply termcap entries when 'keyprotocol' changes#13211
Closed
gpanders wants to merge 2 commits intovim:masterfrom
Closed
Apply termcap entries when 'keyprotocol' changes#13211gpanders wants to merge 2 commits intovim:masterfrom
gpanders wants to merge 2 commits intovim:masterfrom
Conversation
When the 'keyprotocol' option was set after startup (including in a user's .vimrc) the termcap entries associated with the matching protocol were not applied. Thus, setting the option has no affect. When 'keyprotocol' is changed it should also update the termcap entries.
98b8a73 to
f8655ba
Compare
Contributor
Author
|
Test failures look unrelated (looks like they started in 9eb1ce5). |
Member
|
Thanks, I think this makes sense. But can we have a test for this please? |
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #13211 +/- ##
==========================================
- Coverage 82.72% 81.48% -1.25%
==========================================
Files 150 160 +10
Lines 182155 195364 +13209
Branches 40937 43823 +2886
==========================================
+ Hits 150696 159193 +8497
- Misses 18515 23440 +4925
+ Partials 12944 12731 -213
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the 'keyprotocol' option was set after startup (including in a
user's .vimrc) the termcap entries associated with the matching protocol
were not applied. Thus, setting the option has no effect.
When 'keyprotocol' is changed it should also update the termcap entries.