configure.ac: Fix create_timer solaris test for cross compiling#10777
Closed
rpurdie wants to merge 1 commit intovim:masterfrom
Closed
configure.ac: Fix create_timer solaris test for cross compiling#10777rpurdie wants to merge 1 commit intovim:masterfrom
rpurdie wants to merge 1 commit intovim:masterfrom
Conversation
A runtime test was added for create_timer however this meant cross compiling would no longer work. Allow a cache value to be specified to allow cross compiling again. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Codecov Report
@@ Coverage Diff @@
## master #10777 +/- ##
==========================================
- Coverage 81.75% 81.75% -0.01%
==========================================
Files 158 158
Lines 185662 185662
Branches 41985 41985
==========================================
- Hits 151795 151779 -16
- Misses 21393 21401 +8
- Partials 12474 12482 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
13 tasks
Contributor
|
Still having issues with vim timer at 9.0.0065+
checking for timer_create without -lrt... configure: error:
cross-compiling: please set 'vim_cv_timer_create'
The docs for AC_RUN_IFELSE are a bit unclear, but it looks like it
assumes cross-compiling when it cannot link the program. I cannot think
of a way to make a difference, failing to compile because timer_create
is not available and actually cross-compiling cannot be distinguished.
On my system I did not manage to make it give the cross-compiling
message even when passing a non-existing library.
I think we can work around this by adjusting the message to say "if
cross-compiling, then...". And use AC_MSG_WARN instead of AC_MSG_ERROR,
so that configure continues.
…--
hundred-and-one symptoms of being an internet addict:
195. Your cat has its own home page.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A runtime test was added for create_timer however this meant cross compiling
would no longer work. Allow a cache value to be specified to allow cross
compiling again.
Signed-off-by: Richard Purdie richard.purdie@linuxfoundation.org