LSP messages are not parsed properly if the http header and json payload are received separately#10215
Closed
yegappan wants to merge 1 commit intovim:masterfrom
Closed
LSP messages are not parsed properly if the http header and json payload are received separately#10215yegappan wants to merge 1 commit intovim:masterfrom
yegappan wants to merge 1 commit intovim:masterfrom
Conversation
Member
|
Hi Yegappan, could that also fix the issue from the vim-win32-installer repository? |
|
Hi Christian,
On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt < ***@***.***> wrote:
Hi Yegappan, could that also fix the issue from the vim-win32-installer
repository?
Is it possible to do one vim-win32-installer test run with the LSP test
enabled again ?
Thanks,
Yegappan
|
|
On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
Hi Christian,
On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt ***@***.***> wrote:
Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
Yes of course. Once this is merged, I can enable the test again.
Best,
Christian
--
Ein Mensch in einer fremden Stadt fragt:
"Wissen Sie, wo es zum Bahnhof geht?"
Bioenergetiker: "Machen Sie mal sch... sch... sch... !"
|
87786fb to
c6b3381
Compare
Codecov Report
@@ Coverage Diff @@
## master #10215 +/- ##
==========================================
- Coverage 81.01% 80.94% -0.07%
==========================================
Files 161 161
Lines 185331 185500 +169
Branches 41845 41931 +86
==========================================
+ Hits 150149 150160 +11
- Misses 22630 22787 +157
- Partials 12552 12553 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…oad are received separately
|
Hi Christian,
On Sun, Apr 17, 2022 at 1:24 PM Christian Brabandt ***@***.***> wrote:
On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
> Hi Christian,
>
> On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt ***@***.***> wrote:
>
>
> Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
>
>
>
> Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
Yes of course. Once this is merged, I can enable the test again.
It looks like the LSP tests are now passing in the vim-win32-installer
CI but failing somewhere else?
Regards,
Yegappan
|
|
Christian wrote:
> It looks like the LSP tests are now passing in the vim-win32-installer
> CI but failing somewhere else?
Yes, it seems test_alot.vim now times out. I have no idea how to debug
this .(
If needed we can split off things from test_alot.vim and run them
separately. It's a bit more efficient to run multiple tests without
starting a new Vim instance, but if it makes debugging harder that's
more important to fix than efficiency.
…--
Q. What happens to programmers when they die?
A: MS-Windows programmers are reinstalled. C++ programmers become undefined,
anyone who refers to them will die as well. Java programmers reincarnate
after being garbage collected, unless they are in permgen, in which case
they become zombies. Zimbu programmers leave a stack trace that tells us
exactly where they died and how they got there.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
Member
|
Now, It finally worked. I'll keep an eye on that to see if this happens more often. |
2 tasks
|
Am 2022-04-21 17:46, schrieb Yegappan Lakshmanan:
Hi Christian,
On Sun, Apr 17, 2022 at 1:24 PM Christian Brabandt ***@***.***>
wrote:
>
>
> On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
>
> > Hi Christian,
> >
> > On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt ***@***.***> wrote:
> >
> >
> > Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
> >
> >
> >
> > Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
>
> Yes of course. Once this is merged, I can enable the test again.
>
It looks like the LSP tests are now passing in the vim-win32-installer
CI but failing somewhere else?
Yes, it seems test_alot.vim now times out. I have no idea how to debug
this .(
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse all the received data before parsing the LSP messages.