Skip to content

Dev batching refactor#174

Merged
vilbeyli merged 63 commits intodevfrom
dev-batching-refactor
Apr 20, 2025
Merged

Dev batching refactor#174
vilbeyli merged 63 commits intodevfrom
dev-batching-refactor

Conversation

@vilbeyli
Copy link
Copy Markdown
Owner

@vilbeyli vilbeyli commented Mar 19, 2025 •
edited
Loading

  • Move draw call batching from scene to renderer
  • Remove intermediate data buffer for draw data, directly batch into CB, improving command recording performance as well
  • optimize culling + mesh data gather + batching performance with SoA data, aligned and slimmed structs
  • improve thread utilization by introducing TaskSignal<> (future+promise wrapper) and chaining dependent tasks while removing busy waits
  • remove std::unordered_map for Material data, use MemoryPool instead

Before
0Before

After
1After

@vilbeyli
rename F*RenderCommands to F*RenderData
afdb1f6
@vilbeyli
rename RenderParams -> RenderOptions where most of the variables are …
0997b41 
…flags/bools for rendering and not the actual data
@vilbeyli
separate drawdata from the sceneview
553ed3c
@vilbeyli
remove busy wait, use promise/future for signalling for waiting frust…
dff1078 
…um cull results. also re-arrange work around the sync point
@vilbeyli
separate culling and visible mesh data gathering
b80c7df
@vilbeyli
move visibleMeshData into SceneView, remove BBH and Scene parameters …
22ea66b 
…from batching functions
@vilbeyli
update multithreading code, add TaskSignal struct that uses promise/f…
df53849 
…uture pair for signaling
@vilbeyli
use frustum render list struct that embeds a task signal for syncing …
0b624e5 
…workers
@vilbeyli
WIP: move batching to renderer
9080231
@vilbeyli
WIP: fix bounding box draw batching
fd9f2c9
@vilbeyli
draw batching is now done in renderer
8889970
@vilbeyli
remove the forgotten reference to the removed header file
bfe2c7e
@vilbeyli
remove additional memory usage when batching instance data (maps etc)
d1c99b0
@vilbeyli
optimize shadow instance batching cache access
a382f80
@vilbeyli
improve thread utilization between frustum culling and instance batch…
9a91773 
…ing by better signaling
@vilbeyli
remove busy wait between gameobj and mesh bounding box building
eba204f
@vilbeyli
align material data for SSE
05373f3
@vilbeyli
pack tessellation config params
d56863c
@vilbeyli
directly write into CBuffer data
ebcc013
@vilbeyli
sort only the necessary small data, much faster due to cache util
0c3c428
@vilbeyli
SoA cull results for main view (WIP)
671ed18
@vilbeyli
Re-arrange Material, get rid of unnecessary Tessellation struct and r…
c3a7619 
…educe memory size from 216 to 192 Bytes
@vilbeyli
further reduce Material memory footprint from Tessellation factor par…
f521f54 
…ams to 176 Bytes
@vilbeyli
align structs for cache perf when batching instanced draw data, use r…
f848a10 
…anges for draw calls: 1000us -> 850us
@vilbeyli
SoA cull results for shadow views, shadows are buggy
3c2e0da
@vilbeyli
pass by ref to culling, fix pass by copy
4671dc4
@vilbeyli
optimize culling pass, skip memory allocation for sort data and visib…
fb088cf 
…le mesh data & batch culling together
@vilbeyli
don't clear the visible mesh data memory, reset valid element count i…
044e5a0 
…nstead
@vilbeyli
materials in memory pool
fcdf422
@vilbeyli
fix CBHeap thread contention, add mutex'ed version to CBHeap.Alloc()
d5683d2
vilbeyli added 27 commits March 24, 2025 22:21
@vilbeyli
fix nullptr deref + remove a busy wait after mesh bounding box building
d731b11
@vilbeyli
remove busy waits, properly signal next frame
5a98e70
@vilbeyli
tidy up: alignas preprocessor for shader code
3a85a00
@vilbeyli
fix warnings
3a4178e
@vilbeyli
clean up culling worker context
30a977c
@vilbeyli
reduce sort key storage in VisibleSceneData to one
c74f6d9
@vilbeyli
frustum planeset XMFLOAT4 -> XMVECTOR
47f8170
@vilbeyli
fix batching deadlock when there are empty shadow frustums
28f88d6
@vilbeyli
rearrange some include
fd6d445
@vilbeyli
clean up materials
468259d
@vilbeyli
fix SetDescHeap() on closed compute command list when loading scnee
d890f79
@vilbeyli
remove unused header, minor code tidyup
84a0f0e
@vilbeyli
add more markers for startup code
c576789
@vilbeyli
code cleanup, remove dead code
8043501
@vilbeyli
fix compiler error, code cleanup
239c2f0
@vilbeyli
clean up sceneview data
bfc14b5
@vilbeyli
fix deadlock for culled frustum wait signals
bc081e0
@vilbeyli
undo unintended change
30f9ec2
@vilbeyli
fix frustum culling bug from unintended change to frustum plane extra…
0aac7f1 
…ction code
@vilbeyli
fix cull worker starvation by bathc workers -- move signal that start…
7c69cf0 
…s dispatches into after sort is completed and dont queue gather but rather execute it in the same worker after sort
@vilbeyli
fix empty main view frustum rendering (1 object staying on screen)
263a5c8
@vilbeyli
code cleanup: gather static mesh sorting key functions into a file
be240fb
@vilbeyli
code cleanup: remove FShadowView struct, now its a single matrix
28043c7
@vilbeyli
add back render stats bookkeeping
c086836
@vilbeyli
code cleanup: remove InstanceBatching namespace from Scene.h
5358c41
@vilbeyli
code cleanup: fix warnings, remove base class for draw data for bette…
3c2d503 
…r alignment
@vilbeyli
code cleanup: rename scene render data gather functions correctly
54f1d56
@vilbeyli vilbeyli merged commit f773d45 into dev Apr 20, 2025
@vilbeyli vilbeyli deleted the dev-batching-refactor branch April 20, 2025 03:29
@vilbeyli vilbeyli mentioned this pull request Jun 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vilbeyli