Skip to content

fix: update VHS to v3.14.1#8860

Merged
adrums86 merged 3 commits intomainfrom
fix-vhs-v3.14.1
Sep 10, 2024
Merged

fix: update VHS to v3.14.1#8860
adrums86 merged 3 commits intomainfrom
fix-vhs-v3.14.1

Conversation

@adrums86
Copy link
Copy Markdown
Contributor

@adrums86 adrums86 commented Sep 9, 2024

Description

Update VHS to v3.14.1 for a VTT timing fix detailed here: videojs/http-streaming#1537

Specific Changes proposed

Update the VHS package to v.3.14.1.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (1e2ea61) to head (feade03).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8860   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files         120      120           
  Lines        8066     8066           
  Branches     1937     1937           
=======================================
  Hits         6712     6712           
  Misses       1354     1354

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wseymour15
wseymour15 reviewed Sep 9, 2024
View reviewed changes
Comment thread package-lock.json Outdated
@adrums86
Copy link
Copy Markdown
Contributor Author

adrums86 commented Sep 10, 2024

Thank you @Essk!

@adrums86 adrums86 requested a review from wseymour15 September 10, 2024 16:41
@adrums86 adrums86 merged commit c8e546f into main Sep 10, 2024
@adrums86 adrums86 deleted the fix-vhs-v3.14.1 branch September 10, 2024 22:24
@kerasus kerasus mentioned this pull request Oct 2, 2024
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wseymour15 wseymour15 wseymour15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrums86 @wseymour15 @Essk