fix: correct errorMetadata property name from 'erroType' to 'errorType'#1568
Merged
mister-ben merged 1 commit intovideojs:mainfrom Mar 10, 2025
Merged
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
=======================================
Coverage 84.00% 84.00%
=======================================
Files 44 44
Lines 11707 11707
Branches 2623 2623
=======================================
Hits 9834 9834
Misses 1873 1873 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mister-ben
approved these changes
Mar 9, 2025
gkatsev
approved these changes
Mar 9, 2025
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The erroType property in request.timedout is incorrectly named.
While reviewing error-handling behavior, I noticed an inconsistency in the property name. 🔍 Based on the surrounding code context, it should be errorType.
This fix ensures consistency with other error return formats😀
Specific Changes proposed
correct errorMetadata property name from
erroTypetoerrorTypeRequirements Checklist