Multi period dash VOD fixes#1551
Merged
dzianis-dashkevich merged 12 commits intomainfrom Nov 21, 2024
Merged
Conversation
added 4 commits
November 5, 2024 12:57
…aylist trigger for the main segment loader
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
==========================================
- Coverage 84.08% 83.97% -0.11%
==========================================
Files 43 44 +1
Lines 11646 11681 +35
Branches 2604 2612 +8
==========================================
+ Hits 9792 9809 +17
- Misses 1854 1872 +18 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…eriod-dash-vod-fixes
alex-barstow
approved these changes
Nov 21, 2024
adrums86
approved these changes
Nov 21, 2024
| // Adding a slight debounce to avoid duplicate calls during rapid quality changes, for example: | ||
| // When selecting quality from the quality list, | ||
| // where we may have multiple bandwidth profiles for the same vertical resolution. | ||
| this.fastQualityChange_ = debounce(this.fastQualityChange_.bind(this), 100); |
There was a problem hiding this comment.
Thank you for actually adding this! This has been on my list of "quick improvements" to fast quality change for a while and keeps getting buried by other priorities.
| this.tech_.setCurrentTime(newTime); | ||
| }); | ||
|
|
||
| this.timelineChangeController_.on('fixBadTimelineChange', () => { |
There was a problem hiding this comment.
Also love moving this to the playlist-controller level. 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specific Changes proposed
For example, when we select quality from the quality list with multiple bandwidth profiles for the same vertical resolution, it will call for fast quality changes for multiple playlists one by one.
isPausedfor the dash playlist loader. This fixes duplicate load calls whenmediachangeis fired. See this PR for more info fix: Restart masterPlaylistLoader after media change #1339)Requirements Checklist