fix: Ensure native segment metadata track has mode hidden#1550
Merged
dzianis-dashkevich merged 2 commits intovideojs:mainfrom Feb 5, 2025
Merged
fix: Ensure native segment metadata track has mode hidden#1550dzianis-dashkevich merged 2 commits intovideojs:mainfrom
dzianis-dashkevich merged 2 commits intovideojs:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
=======================================
Coverage 83.99% 83.99%
=======================================
Files 44 44
Lines 11699 11700 +1
Branches 2618 2618
=======================================
+ Hits 9826 9827 +1
Misses 1873 1873 ☔ View full report in Codecov by Sentry. |
phloxic
reviewed
Oct 31, 2024
Contributor
phloxic
left a comment
There was a problem hiding this comment.
typo in commit message: s/mdoe hidden/mode hidden/
c79ea09 to
fd19b3f
Compare
dzianis-dashkevich
approved these changes
Feb 5, 2025
| label: 'segment-metadata' | ||
| }, false).track; | ||
|
|
||
| this.segmentMetadataTrack_.mode = 'hidden'; |
Contributor
There was a problem hiding this comment.
I thought it is possible to pass mode as an option to add remote text track
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using native text tracks, the segment metadata track was being created with mode
disabled. This meant it wouldn't triggercuechangeevents, but also Chrome (at least) does not add cues to disabled tracks. This change makes the track start outhidden.Specific Changes proposed
hiddenaddSegmentMetadataCue_is made noop in the tests.Requirements Checklist