feat: Add experimental support for ManagedMediaSource#1453
Merged
mister-ben merged 14 commits intovideojs:mainfrom Aug 23, 2024
Merged
feat: Add experimental support for ManagedMediaSource#1453mister-ben merged 14 commits intovideojs:mainfrom
mister-ben merged 14 commits intovideojs:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
- Coverage 86.36% 86.36% -0.01%
==========================================
Files 43 43
Lines 11144 11151 +7
Branches 2545 2548 +3
==========================================
+ Hits 9625 9631 +6
- Misses 1519 1520 +1 ☔ View full report in Codecov by Sentry. |
gkatsev
approved these changes
Nov 29, 2023
Contributor
Author
|
Adding as |
|
Hi, any news? |
dzianis-dashkevich
approved these changes
Aug 22, 2024
mister-ben
commented
Aug 23, 2024
This was referenced Sep 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic support for ManagedMediaSource. Must be enabled with the
useManagedMediaSourceVHS option.Does not implement an alternate AirPlay source - this requires a more significant change, to add two source els. This means remote playback has to be disabled on the video el when using MMS.
Event listeners for advanced control are not yet implemented -
startstreaming,endstreaming,qualitychange