fix: playlists wrongfully excluded on iOS when using ManagedMediaSource#1555
Merged
alex-barstow merged 3 commits intomainfrom Nov 27, 2024
Merged
fix: playlists wrongfully excluded on iOS when using ManagedMediaSource#1555alex-barstow merged 3 commits intomainfrom
alex-barstow merged 3 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 44 44
Lines 11681 11683 +2
Branches 2612 2612
=======================================
+ Hits 9807 9809 +2
Misses 1874 1874 ☔ View full report in Codecov by Sentry. |
adrums86
approved these changes
Nov 27, 2024
wseymour15
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
browserSupportsCodec()vhs-utils method was recently updated to support cases whereManagedMediaSourceis supported and in use. This is accomplished by passing a 2nd argumentwithMMSthat defaults tofalse. Invocations ofbrowserSupportsCodec()in VHS weren't passing this 2nd arg, resulting in cases on iOS (whereMediaSourceisn't supported) where VHS thought errantly that supported codecs were not supported, resulting in playlists being wrongly excluded.Specific Changes proposed
ManagedMediaSourceis being usedbrowserSupportsCodec()callsRequirements Checklist