Ported into net standard 2.0 #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Note to consider: This removes support for older platforms, e.g. UWP pre-Fall Creators Update. |
Collaborator
|
@charlesroddie Is this acceptable? |
Contributor
Author
|
Maybe we can keep another dedicated branch for netstandard 2.0 ? |
Collaborator
netstandard2.0 makes sense as hygiene. This PR isn't complete. There are some references to things that can't be done in netstandard1.3 (analyzers) that can be removed/fixed, and bound to be some other things that are enabled by netstandard2.0.
Too complex and the main benefit of this PR will be simplification. |
Collaborator
|
The analyzer doesn't do much yet to be useful by itself, but serves as a future extension point. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.