Skip to content

Provide workaround for #192 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Happypig375 merged 1 commit into from
May 5, 2021
Merged

Provide workaround for #192 #193

Happypig375 merged 1 commit into from
May 5, 2021

Conversation

@Happypig375
Copy link
Collaborator

@Happypig375 Happypig375 commented May 4, 2021 •
edited
Loading

So that

class RussianBreakingEngine : Typography.TextBreak.EngBreakingEngine {
  public override bool CanHandle(char c) => c is >= '\u0400' and <= '\u052f'; // Unicode Cyrillic and Cyrillic Supplement
}
CSharpMath.Rendering.Text.TextLaTeXParser.AdditionalBreakingEngines.Add(new RussianBreakingEngine());

can be used for #192 while awaiting Typography support.

@Happypig375 Happypig375 requested a review from FoggyFinder May 4, 2021 10:34
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #193 (0964242) into master (a7e11ba) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   87.34%   87.32%   -0.02%     
==========================================
  Files         156      156              
  Lines       11329    11332       +3     
==========================================
+ Hits         9895     9896       +1     
- Misses       1434     1436       +2
Impacted Files Coverage Δ
CSharpMath.Rendering/Text/TextLaTeXParser.cs 87.76% <33.33%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e11ba...0964242. Read the comment docs.

@Happypig375 Happypig375 requested a review from charlesroddie May 5, 2021 02:31
@Happypig375 Happypig375 merged commit 69fb790 into master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FoggyFinder FoggyFinder FoggyFinder approved these changes

@charlesroddie charlesroddie Awaiting requested review from charlesroddie

Assignees

No one assigned

Labels

Type/Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Happypig375 @codecov-commenter @FoggyFinder