-
Notifications
You must be signed in to change notification settings - Fork 71
upgrade avalonia pkg to 0.10.0 #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade avalonia pkg to 0.10.0 #186
Conversation
|
Not totally clear why build is failed. I'll take a look tomorrow if you don't fix it before. |
|
I tried to revert the change just to verify if build process work but it seems it doesn't depend on the avalonia pkg upgrade. Actually I'm using CSharpMath lib through direct source ref from my project using latest avalonia without issues: Directory.Build.props <Project>
<PropertyGroup>
<!-- <AvaloniaVersion>0.10.0-preview5</AvaloniaVersion> -->
<AvaloniaVersion>0.10.0-rc1</AvaloniaVersion>
<CSharpMathVersion>0.5.0-beta</CSharpMathVersion>
</PropertyGroup>
</Project>csproj <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="AngouriMath" Version="1.2.0-preview.5" />
<PackageReference Include="Avalonia.Desktop" Version="$(AvaloniaVersion)" />
<!-- <PackageReference Include="CSharpMath.Avalonia" Version="$(CSharpMathVersion)" /> -->
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\CSharpMath\CSharpMath.Avalonia\CSharpMath.Avalonia.csproj" />
</ItemGroup>
</Project> |
|
Yep, it is something else. Can you revert back? |
I did it |
|
Can you also update the sample project to make it runnable? (i.e. use new style of defining theme etc) |
|
sry I didn't notice of that change, theme uri, because I not used in my example, now updated so avalonia example is runnable cd CSharpMath.Avalonia.Example
dotnet run |
|
I tried to fix build in #187 and while one was easy to fix the rest isn't obvious. But I think this PR can be merged in before. |
|
Yep, I seen with #187 now Build/Everything works, still pb with test about missing refrence of dotnet test CSharpMath.CrossPlatform.slnf -c Release -l GitHubActions --blame --collect:"XPlat Code Coverage" -r .testcoverage -p:PackageReleaseNotes="$RELEASE_NOTES" -p:PackageVersion=187-pr-ci-d97230fd6070d60c60175129ab3dc8cb85228437 -- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.IncludeTestAssembly=trueit finishes without errors. I gotten that type of errors sometimes when a project reference an avalonia version while another uses another one, but may also because there is the need to add some ref like https://www.nuget.org/packages/System.Drawing.Common/ or https://www.nuget.org/packages/Microsoft.Windows.Compatibility/ It may useful to change avalonia ref in this file, may using Another option is to upgrade examples from netcoreapp3.1 to net5.0 and leave libraries as netstandard2.0 that actually grant better cross platform; may in a future with net6.0 there could a unified solution about ( https://devblogs.microsoft.com/dotnet/the-future-of-net-standard/ ) to include android and ios. |
That tests released packages and should use the Avalonia version currently referenced on NuGet. |
jp2masa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this PR is active, Avalonia 0.10 was released in the meanwhile, here are some suggested changes.
|
@devel0 Would you like to accept changes suggested above or better to merge it to the master as is and then open a separate PR for them? |
Co-authored-by: jp2masa <jp2masa@users.noreply.github.com>
use FluentTheme xaml constructor Co-authored-by: jp2masa <jp2masa@users.noreply.github.com>
|
@FoggyFinder accepted all suggestions apart for FluentTheme constructor argument-less from code because seems there aren't such construction mode from code ( it may work using dependency injection but for the example could enough using uri spec ) |
|
@FoggyFinder I am busy on other projects right now, you can have the say on this one. |
I've read your mind :-) Done it one minute before the comment was posted |
1 similar comment
I've read your mind :-) Done it one minute before the comment was posted |
fix avalonia high cpu usage on linux ( AvaloniaUI/Avalonia#5192 )