Skip to content

Killing four bugs with one PR? #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Happypig375 merged 4 commits into from
Jul 18, 2020
Merged

Killing four bugs with one PR? #144

Happypig375 merged 4 commits into from
Jul 18, 2020

Conversation

@Happypig375
Copy link
Collaborator

@Happypig375 Happypig375 commented Jul 16, 2020 •
edited
Loading

This should finish #123, #136, #137 and possibly #138.

@Happypig375 Happypig375 requested a review from FoggyFinder July 16, 2020 15:23
@Happypig375
Copy link
Collaborator Author

Happypig375 commented Jul 16, 2020

Now the view output of CSharpMath.Avalonia and CSharpMath.SkiaSharp are the same.
image

Should we decrease the default font size (50)? Seems a bit too large.

@Happypig375 Happypig375 mentioned this pull request Jul 16, 2020
Open
@FoggyFinder
Copy link
Collaborator

FoggyFinder commented Jul 17, 2020

Something is not right with these changes.
Text in display mode reacts on mouse dragging:

_144

@Happypig375
Copy link
Collaborator Author

Happypig375 commented Jul 17, 2020 •
edited
Loading

Maybe we should remove panning/dragging. It is from a time when view sizes were buggy and views are required to fill the entire available size. Panning/dragging is also buggy on Avalonia (the hit detection requires you to click a non-transparent pixel requiring precise cursor movement, and you can drag out of view bounds). Now that view sizes is getting fixed (#32, #136), we should replace all uses of panning/dragging with ScrollViews.

If we are to remove panning/dragging anyways, we might as well ignore this issue for now.

@FoggyFinder
Copy link
Collaborator

FoggyFinder commented Jul 17, 2020

we should replace all uses of panning/dragging with ScrollViews.

What about line breaks then ? (or I didn't get the point how it will be implemented)

@Happypig375
Copy link
Collaborator Author

Happypig375 commented Jul 18, 2020 •
edited
Loading

Panning/dragging is independent of line breaking. People can already use TextView in ScrollView as seen in #136.

@FoggyFinder FoggyFinder self-requested a review July 18, 2020 06:02
@Happypig375 Happypig375 merged commit f75643d into master Jul 18, 2020
@Happypig375 Happypig375 deleted the issue136/DpiCalculations branch July 18, 2020 14:19
@Happypig375 Happypig375 added Resolution/Fixed The described issue is fixed. Status/5. Awaiting next release This issue has been resolved and is waiting for the next release/prerelease. labels Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FoggyFinder FoggyFinder FoggyFinder approved these changes

Assignees

No one assigned

Labels

Resolution/Fixed The described issue is fixed. Status/5. Awaiting next release This issue has been resolved and is waiting for the next release/prerelease. Type/Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Happypig375 @FoggyFinder