Add full placeholder when it's convenient #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happypig375
reviewed
Dec 11, 2019
| case MathAtomType.Fraction: | ||
| case MathAtomType.Ordinary: | ||
| // functions are treated as a LargeOperator so no special case here. Yet? | ||
| case MathAtomType.LargeOperator: |
Collaborator
There was a problem hiding this comment.
LargeOperators have special handling for positioning of superscripts and subscripts. They always support them.
Happypig375
reviewed
Dec 11, 2019
| return false; | ||
| default: | ||
| return true; | ||
| } |
Collaborator
There was a problem hiding this comment.
Will a blacklist-based approach be better? It seems that adding a placeholder is the minority case and new cases for MathAtomType should support direct scripts by default.
Collaborator
Author
There was a problem hiding this comment.
Maybe even black & white lists with default false?
Collaborator
There was a problem hiding this comment.
In this case, a switch expression should be used for exhaustiveness warnings.
Collaborator
Author
There was a problem hiding this comment.
Played a bit with both approaches. Now I also see more advantages of having the single list. You're totally right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #47