This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Small updates of exploring the test WP site after tests have run#1411
Merged
Small updates of exploring the test WP site after tests have run#1411
Conversation
This is a better way to start the Docker stack for exploring failed tests.
It now only stops and removes but keeps the volumes so that `npm run tests -- --explore` can be run again. Volumes are deleted automatically when tests start.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1389
I wanted to get rid of the very slow copying of files between Docker volumes and the host OS (
npm run tests:copy-files-to-host) via Samba as mentioned here: #1389 (comment). However, I couldn't make it work and it seems quite complex, see e.g. this Reddit post.So this PR is only about small improvements like introducing a new
--exploreoption torun-tests.tsand updating the documentation.One change in behavior is that
npm run tests:cleanupnow keep volumes. This has the advantage thatnpm run tests -- --explorecan be run again when necessary; volumes are cleaned up when tests start. See d58676d.