Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

Docker Toolbox on Windows – notes#1403

Merged
borekb merged 6 commits intomasterfrom
1389-docker-toolbox
Mar 26, 2019
Merged

Docker Toolbox on Windows – notes#1403
borekb merged 6 commits intomasterfrom
1389-docker-toolbox

Conversation

@borekb
Copy link
Copy Markdown
Member

@borekb borekb commented Mar 17, 2019

Issue: #1389

As part of #1389, I'm verifying that tests:full run on Docker Toolbox for Windows. This PR documents the process and adds a couple of notes to the docs.

@borekb borekb added the scope: tests Testing code. For infrastructure (CI, etc.), use "dev-infrastructure". label Mar 17, 2019
@borekb borekb added this to the 4.0 milestone Mar 17, 2019
@borekb borekb self-assigned this Mar 17, 2019
@borekb
Copy link
Copy Markdown
Member Author

borekb commented Mar 17, 2019

The tests are at least running!

image

I'm testing on an old Windows laptop (~2014 HP ProBook 650) that I wiped and updated to the latest Windows 10 version. These were the steps I then followed:

Install VSCode.

Install Git for Windows. (I generally prefer MSYS2 but wanted to stay closer to what most people would run.)

  • Select "Use Git and optional Unix tools..." option.
  • Select "Check out as-is, commit as-is" option.

Do a rudimentary Git setup (copy .gitconfig from GitHub etc.).

Install ConEmu, a sane terminal.

Install Docker Toolbox.

Install Node.js.

The I remembered that Scoop exists so I installed that.

Install PHP (v7.3 at the time of writing):

scoop install php-nts

Enable PHP extension by following this: https://github.com/lukesampson/scoop/wiki/Custom-PHP-configuration.

Install Composer:

scoop install composer

Then I was able to start the Docker Quickstart Terminal, configure port forwarding and folder sharing (see updated dev-setup.md in a13ba8f) and run tests. Unit tests passed:

npm run tests:unit

@borekb
Copy link
Copy Markdown
Member Author

borekb commented Mar 17, 2019

Great, I'm getting consistent results with Docker for Mac, #1400 (comment):

image

It took about half an hour, maybe a bit more, which is again quite similar to what I'm seeing on Mac, currently (I can no longer reproduce the 10-minute runs, see #1400 (comment)).

@borekb borekb marked this pull request as ready for review March 18, 2019 07:07
@borekb borekb requested a review from pavelevap March 18, 2019 07:07
Copy link
Copy Markdown
Collaborator

@pavelevap pavelevap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My experience was not so smooth, but it is probably caused by slower computer (maybe also Windows 7 or some special settings, I am not sure yet). But in the end tests "work" also on my machine with the same results.

@borekb
Copy link
Copy Markdown
Member Author

borekb commented Mar 19, 2019

Waiting is implemented in #1401 if that was part of the problem...

@pavelevap, if you have more tips or notes to share, feel free to add them, otherwise, I'm going to merge this later today.

@borekb
Copy link
Copy Markdown
Member Author

borekb commented Mar 19, 2019

Also worth noting is that Travis now supports Windows so it would be a good idea to run tests on Windows automatically (though it most likely won't be via Toolbox). See #1259 (comment).

@borekb
Copy link
Copy Markdown
Member Author

borekb commented Mar 24, 2019

I've updated the section on Docker Toolbox performance after my recent experiments in #1401 (comment).

@borekb borekb requested a review from pavelevap March 25, 2019 10:33
@borekb borekb changed the title Test runs in Docker Toolbox on Windows Docker Toolbox on Windows – notes Mar 26, 2019
@borekb borekb added the scope: docs Markdown documentation, public docs, READMEs label Mar 26, 2019
@borekb borekb merged commit 1a21fcb into master Mar 26, 2019
@borekb borekb deleted the 1389-docker-toolbox branch March 26, 2019 07:34
@borekb
Copy link
Copy Markdown
Member Author

borekb commented Apr 18, 2019

On the laptop (2014 HP ProBook 650), I upgraded from Docker Toolbox to Docker Desktop (had to completely reinstall the machine as Hyper-V was failing to activate after VirtualBox had been previously installed 🙄).

The tests ran for a much more reasonable 16 minutes - it was 37 before and the best times we're getting on powerful MacBooks or on TravisCI are about 11 minutes. So not too bad.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope: docs Markdown documentation, public docs, READMEs scope: tests Testing code. For infrastructure (CI, etc.), use "dev-infrastructure".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants