Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

Upgrade to PHP_CodeSniffer and fix newly identified issues#1377

Merged
borekb merged 2 commits intoversionpress:masterfrom
candrews:fix-codesniffer
Mar 4, 2019
Merged

Upgrade to PHP_CodeSniffer and fix newly identified issues#1377
borekb merged 2 commits intoversionpress:masterfrom
candrews:fix-codesniffer

Conversation

@candrews
Copy link
Copy Markdown
Contributor

@candrews candrews commented Mar 4, 2019

Upgrade to the latest PHP_CodeSniffer (3.4.0). ( cd plugins/versionpress && ./vendor/bin/phpcs --standard=ruleset.xml ) then fails due to formatting issues; so fix those issues.

@candrews candrews changed the title Fix issues identified by PHP_CodeSniffer Upgrade to PHP_CodeSniffer and fix newly identified issues Mar 4, 2019
@borekb
Copy link
Copy Markdown
Member

borekb commented Mar 4, 2019

Looks good, thank you!

@borekb borekb merged commit d683ea3 into versionpress:master Mar 4, 2019
@borekb borekb added the scope: dev-infrastructure Build scripts, IDE settings, CI, Docker dev stack, testing, tooling, etc. label Mar 4, 2019
@borekb borekb added this to the 4.0 milestone Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope: dev-infrastructure Build scripts, IDE settings, CI, Docker dev stack, testing, tooling, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants