This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Make getMenuReference return "terms" instead of "term_taxonomy"#1370
Merged
JanVoracek merged 1 commit intoversionpress:masterfrom Jan 28, 2019
Merged
Make getMenuReference return "terms" instead of "term_taxonomy"#1370JanVoracek merged 1 commit intoversionpress:masterfrom
JanVoracek merged 1 commit intoversionpress:masterfrom
Conversation
Contributor
|
@borekb can you please take a look at this? |
Member
|
👍 looks good to me. I'll add @JanVoracek as a reviewer. |
|
@JanVoracek any thoughts? Nice work @lframnes!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1369
This is a one liner to address the bug described in 1369. With this change the INI file will contain a VP ID for "terms" instead of "term taxonomy". This will align with the data Wordpress stores in the postmeta when a category navigation item is saved.
Here is a before/after comparison of the change as relates to the DB/INI data.