This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Add error when re-activating VP with WP-CLI#1314
Merged
borekb merged 1 commit intoversionpress:masterfrom Jan 18, 2018
x1024:master
Merged
Add error when re-activating VP with WP-CLI#1314borekb merged 1 commit intoversionpress:masterfrom x1024:master
borekb merged 1 commit intoversionpress:masterfrom
x1024:master
Conversation
Member
|
Nice! I also like your explanation why it's an error. The only thing I've noticed is that a file mode is changed as well:
That might not be intentional. |
Member
|
Related to this, I'm question the term "active" as we use it: versionpress/plugins/versionpress/src/VersionPress.php Lines 31 to 37 in 4fd7569 What's your opinion, isn't it too close to "activated" and therefore confusing? |
Contributor
Author
|
I updated the commit again. The permissions change was unintentional. "isActive" is descriptive enough, and during the installation process it was made obvious what that means. I don't think there is a need to change that. |
JanVoracek
approved these changes
Jan 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1313
The logging message is at the "error" level, because that's the logging level for doing "wp core download" a second time.