This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Merged
Conversation
- Posts had both `edit` and `update` actions but I couldn't find where the `update` one was used. So there's now just a single `update` action, replacing the `edit` one as with other scopes. - One exception where both `update` and `edit` are valid are plugins and themes: the `update` action means updating to a new version, `edit` is editing plugin / theme files. - `EditActionChangeInfoPreprocessor` class renamed to `UpdateActionChangeInfoPreprocessor` and refactored a bit to fit the new naming.
# Conflicts: # plugins/versionpress/tests/End2End/Comments/CommentsTest.php
JanVoracek
approved these changes
Jul 4, 2017
Member
Author
|
Thanks for the update, @JanVoracek, I've updated the PR description to indicate that this change is backwards compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1120
All legacy
editactions converted toupdate. There are some cases where both actions are still valid, e.g., plugin and themes have both theupdate(to a new version) andedit(plugin/theme files) actions.The change is backwards compatible: if the
editaction comes toTrackedChangeInfoand the scope doesn't have a proper description for it, it is upgraded to theupdateaction. See fb432e6.