This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Added VP_WP_CLI_BINARY option to vp config#1187
Merged
JanVoracek merged 3 commits intoversionpress:masterfrom Jun 27, 2017
Merged
Added VP_WP_CLI_BINARY option to vp config#1187JanVoracek merged 3 commits intoversionpress:masterfrom
JanVoracek merged 3 commits intoversionpress:masterfrom
Conversation
Member
|
Thanks, @LorincJuraj, we'll look at it soon. |
borekb
suggested changes
Jan 24, 2017
Member
borekb
left a comment
There was a problem hiding this comment.
Looks good to me apart from one small issue, thanks! Let's wait for @JanVoracek's review – he is a bit busy these days but should be able to look at it later this week.
plugins/versionpress/bootstrap.php
Outdated
| define('VP_GIT_BINARY', 'git'); | ||
| } | ||
|
|
||
| if (!defined('VP_GIT_BINARY')) { |
Member
There was a problem hiding this comment.
Duplicates the block above, probably an oversight.
Contributor
Author
| * VP_VPDB_DIR: Absolute path to directory where VersionPress saves | ||
| * versioned database data. | ||
| * VP_GIT_BINARY: Absolute path to the git binary. | ||
| * VP_WP_CLI_BINARY: Absolute path to the WP-CLI binary. |
Member
There was a problem hiding this comment.
The new implementation maybe even allows defining VP_WP_CLI_BINARY as 'php wp-cli.phar'; I can imagine that could be useful sometimes. Is that correct?
Contributor
There was a problem hiding this comment.
It does not allow php wp-cli.phar as it can be only an absolute path. wp vp config checks whether the file exists.
borekb
approved these changes
Jan 25, 2017
…ownloads its own WP-CLI
JanVoracek
approved these changes
Jun 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1186
Creates new config constant which gives an option to set custom path to WP-CLI.
Works same way as VP_GIT_BINARY:
wp vp config VP_WP_CLI_BINARY '/custom/path/to/wp'Followup PR with docs: #1340