This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Refactor of HomePage component and directory structure#1115
Merged
Conversation
| isLoading: false, | ||
| displayUpdateNotice: false, | ||
| }); | ||
| this.checkUpdate(); |
Contributor
There was a problem hiding this comment.
@Ishirak: Why is this line removed? If the checkUpdate is not called after fetching commits there could be short (<10s) inconsistency between the commits table and the CommitPanel.
Contributor
Author
There was a problem hiding this comment.
You are right, I thought that in this case setState() would behave as an asynchronous method, as usual, but it doesn't, as I just checked. I will revert this change in the next commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1087.
Last piece to close #1087 – major refactor of front end codebase will be over.
Reviewers: