This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Merged
Conversation
… stylistic issues.
…d OverviewLine bug.
Contributor
|
I think that having a component for each scope (Post, Comment, WordPressUpdate, ...) is not very convenient as the scopes are dynamically defined by |
# Conflicts: # frontend/src/Commits/CommitsTableRowSummary.react.tsx # frontend/src/Commits/revertDialog.tsx # frontend/src/commit-panel/commit/Commit.tsx # frontend/src/common/ConfirmDialog.less # frontend/src/common/Modal.less # frontend/src/common/confirm-dialog/ConfirmDialog.less # frontend/src/common/modal/Modal.less # frontend/src/common/portal.tsx # frontend/src/common/portal/portal.tsx # frontend/src/modal/Modal.less # frontend/src/modal/Modal.react.tsx # frontend/src/modal/dialogs/ConfirmDialog.less # frontend/src/modal/dialogs/ConfirmDialog.react.tsx # frontend/src/modal/portal.tsx # frontend/src/pages/HomePage.react.tsx
Contributor
|
@JanVoracek I am aware of that but for the scope of this PR I only refactored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves (partialy) #1087.
Last major refactor of front end codebase.
Refactor of
HomePagecomponent will be the last piece to close #1087, but its refactor can only begin after this and #1110 are reviewed and merged.Reviewers: