This repository was archived by the owner on Jul 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 239
This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Date modified not handled properly #588
Copy link
Copy link
Labels
bugBugs. For major ones, add "major".Bugs. For major ones, add "major".majorUse only for bugs to mark the big onesUse only for bugs to mark the big onesneeds-migrationBreaking change between VP versions due to a change in storage format. Needs migration.Breaking change between VP versions due to a change in storage format. Needs migration.noteworthySignificant issue or PR, to be highlighted in release notesSignificant issue or PR, to be highlighted in release notesscope: coreCore VersionPress functionality like tracking actions, creating Git commits, etc.Core VersionPress functionality like tracking actions, creating Git commits, etc.size: lEffort: 3-5 daysEffort: 3-5 days
Milestone
Description
In the early alphas and betas of VersionPress, we encountered an issue with "date modified" -- specifically the DB columns post_modified and post_modified_gmt -- which was causing issues in revert scenarios (and would later cause issues during sync). We then decided to compute the date from the Git history, see #73.
However, that was a bad idea. We missed one important scenario: posts that were created before VersionPress started tracking the site. We currently do not have any information about them in the Git repository so restoring them by wp vp restore-site command or in sync scenarios gives them wrong post modification dates.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugBugs. For major ones, add "major".Bugs. For major ones, add "major".majorUse only for bugs to mark the big onesUse only for bugs to mark the big onesneeds-migrationBreaking change between VP versions due to a change in storage format. Needs migration.Breaking change between VP versions due to a change in storage format. Needs migration.noteworthySignificant issue or PR, to be highlighted in release notesSignificant issue or PR, to be highlighted in release notesscope: coreCore VersionPress functionality like tracking actions, creating Git commits, etc.Core VersionPress functionality like tracking actions, creating Git commits, etc.size: lEffort: 3-5 daysEffort: 3-5 days