Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

WP-CLI / Selenium worker switching – revised approach #1258

@borekb

Description

@borekb

Before #1227, end2end tests used to be run with WP-CLI or Selenium workers by switching a value in test-config.yml:

# Worker type to run the tests, 'selenium' or 'wp-cli'
end2end-test-type: selenium

IMO, this was always a bit of a hack as test-config was created to support various local testing environments, not to parameterize test runs – for that, we have TestRunnerOptions.php.

I see two options how to resolve this:

  1. Move end2end-test-type to test runner options (and possibly rename it to end2end-workers or just workers).
  2. Create two sets of test classes, one that runs with Selenium and one with WP-CLI, and get rid of runtime switching entirely.

I'd probably prefer the latter option as npm run tests should IMO truly run all the tests, not "either or".

Metadata

Metadata

Assignees

No one assigned

    Labels

    improvementImprovement of an existing functionality. See "feature" for new features.scope: testsTesting code. For infrastructure (CI, etc.), use "dev-infrastructure".size: mEffort: a day or two

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions