[sglang] chore: Upgrade SGLang 0.4.9 with multi-stage awake feature#2187
Closed
hebiao064 wants to merge 34 commits intoverl-project:mainfrom
Closed
[sglang] chore: Upgrade SGLang 0.4.9 with multi-stage awake feature#2187hebiao064 wants to merge 34 commits intoverl-project:mainfrom
hebiao064 wants to merge 34 commits intoverl-project:mainfrom
Conversation
Collaborator
eric-haibin-lin
left a comment
There was a problem hiding this comment.
does installing sglang now require nvcc?
Collaborator
Author
The newer version of SGLang relies on the flashinfer 0.2.6, which didn't provide aot binary as previous version did flashinfer-ai/flashinfer#1064 Hence we may need nvcc to make sure flashinfer works, I think vllm also need flashinfer, is it possible to bake nvcc into the CI? |
eric-haibin-lin
approved these changes
Jun 27, 2025
Collaborator
eric-haibin-lin
left a comment
There was a problem hiding this comment.
good to go as long as CI tests pass
7 tasks
7 tasks
Collaborator
|
Wait for us to fix Megatron of VLM |
7 tasks
6 tasks
Collaborator
|
Great job so far. |
hebiao064
commented
Jul 7, 2025
…to upgrade_sglang
Collaborator
Author
|
Given flash-attn 2.8.0.post2 (required by torch 2.7) has some issues for apply rotary kernel, huggingface/transformers#39167 (comment) I'll disable the CI for qwen2.5vl sglang test: e2e_ppo_trainer_sglang_vlm |
7 tasks
Collaborator
Author
|
duplicated with #2794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade SGLang 0.4.8 with multi-stage awake function
I build the sglang docker file based on the https://github.com/volcengine/verl/blob/main/docker/verl0.5-cu126-torch2.7.1-fa2.8.0/Dockerfile.app.sglang.mcore0.12
(Only 2 line change about bumping sglang from 0.4.8 to 0.4.9)
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
GRPO Test with SGLang works as expected
API and Usage Example
# Add code snippet or script demonstrating how to use thisHigh-Level Design
Specific Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace.