Skip to content

[node] Skip TS compile for .d.ts assets#7918

Merged
kodiakhq[bot] merged 3 commits intomainfrom
skip-compile-d-ts
Jun 6, 2022
Merged

[node] Skip TS compile for .d.ts assets#7918
kodiakhq[bot] merged 3 commits intomainfrom
skip-compile-d-ts

Conversation

@styfle
Copy link
Member

@styfle styfle commented Jun 5, 2022 •
edited
Loading

Fixes an issue where .d.ts assets were incorrectly being compiled after a fix to nft in vercel/nft#289

Error! An unexpected error occurred in build: TypeError: Unable to require `.d.ts` file.
This is usually the result of a faulty configuration or import. Make sure there is a `.js`, `.json` or another executable extension and loader (attached before `ts-node`) available alongside `test.d.ts`.
    at getOutputTypeCheck (node_modules/@vercel/node/dist/index.js:104574:27)
    at compile (node_modules/@vercel/node/dist/index.js:104645:109)
    at compileTypeScript (node_modules/@vercel/node/dist/index.js:104059:31)
    at Job.readFile (node_modules/@vercel/node/dist/index.js:104085:30)
    at Job.emitDependency (node_modules/@vercel/node/dist/index.js:61748:39)
    at node_modules/@vercel/node/dist/index.js:61762:21
    at async Promise.all (index 0)
    at Job.emitDependency (node_modules/@vercel/node/dist/index.js:61757:9)
    at async Promise.all (index 0)
    at Object.nodeFileTrace (node_modules/@vercel/node/dist/index.js:61499:5)

@styfle styfle added area: node semver: patch PR contains bug fixes labels Jun 5, 2022
TooTallNate
TooTallNate reviewed Jun 5, 2022
View reviewed changes
@styfle styfle requested a review from TooTallNate June 5, 2022 22:48
@kodiakhq kodiakhq bot merged commit 9b08e72 into main Jun 6, 2022
@kodiakhq kodiakhq bot deleted the skip-compile-d-ts branch June 6, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa

+1 more reviewer

@pvdz pvdz pvdz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: node semver: patch PR contains bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@styfle @TooTallNate @pvdz