Skip to content

[backends] Fix build crash for unresolvable workspace deps#15667

Merged
jeffsee55 merged 2 commits intomainfrom
jeffsee55/backends-ws-deps
Mar 26, 2026
Merged

[backends] Fix build crash for unresolvable workspace deps#15667
jeffsee55 merged 2 commits intomainfrom
jeffsee55/backends-ws-deps

Conversation

@jeffsee55
Copy link
Copy Markdown
Contributor

Summary

  • Fix build crash when a workspace dep can't be resolved by rolldown (e.g. missing exports/main). The plugin was adding a bogus path like join(workPath, '@repo/pkg') to localBuildFiles, causing NFT to crash with File .../@repo/pkg does not exist.
  • Fix isTypeScriptFile in NFT to exclude .d.ts files, aligning with the cervel implementation
  • Expand monorepo workspace dep test coverage with new fixture packages (@repo/ts-utils with exports field, @repo/shared-types with types + values) and files.json assertions

Test plan

  • Regression test: does not crash when a workspace dep cannot be resolved — injects an unresolvable bare import and asserts build completes
  • Fixture 17 now asserts workspace dep transpiled files are in the lambda (files.json)
  • Full test suite passes (27 tests)

🤖 Generated with Claude Code

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants