Skip to content

[cli] A few small tweaks to vc certs ls#12395

Merged
kodiakhq[bot] merged 3 commits intomainfrom
certs-ls-tweaks
Oct 26, 2024
Merged

[cli] A few small tweaks to vc certs ls#12395
kodiakhq[bot] merged 3 commits intomainfrom
certs-ls-tweaks

Conversation

@TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Oct 25, 2024

Follow-up to #12383.

  • Drop the /now from the get certs endpoint.
  • Add missing await on expect(promise) call.
  • Remove .todo() from test so that they actually run.
  • Fix failing test that is now running.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: a5fbdd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kodiakhq kodiakhq bot merged commit db06665 into main Oct 26, 2024
@kodiakhq kodiakhq bot deleted the certs-ls-tweaks branch October 26, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants