Skip to content

Remove asserts on mock function#12359

Merged
kodiakhq[bot] merged 2 commits intomainfrom
austinmerrick/remove-unnecessary-mock-test
Oct 24, 2024
Merged

Remove asserts on mock function#12359
kodiakhq[bot] merged 2 commits intomainfrom
austinmerrick/remove-unnecessary-mock-test

Conversation

@onsclom
Copy link
Contributor

@onsclom onsclom commented Oct 23, 2024

These asserts only test the useProject mock, not project add logic. Thanks for catching this @trek!

#12340 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 0d71cbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kodiakhq kodiakhq bot merged commit 7129682 into main Oct 24, 2024
@kodiakhq kodiakhq bot deleted the austinmerrick/remove-unnecessary-mock-test branch October 24, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants