Skip to content

Update "undici" package dependency of vercel/node pkg#10761

Closed
martinez-hugo wants to merge 8 commits intovercel:mainfrom
martinez-hugo:update-prod-pkg
Closed

Update "undici" package dependency of vercel/node pkg#10761
martinez-hugo wants to merge 8 commits intovercel:mainfrom
martinez-hugo:update-prod-pkg

Conversation

@martinez-hugo
Copy link

@martinez-hugo martinez-hugo commented Oct 24, 2023

This refer to this threat : GHSA-wqq4-5wpv-mx2g

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: 7ceb8ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/node Patch
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Nathan Rajlich <n@n8.io>
@martinez-hugo
Copy link
Author

Thanks @Ethan-Arrowood
Do you think that you can approve on Vercel this request ?

@martinez-hugo
Copy link
Author

Thanks @cb1kenobi ! There are a problem I think about changeset, but I don't know about what.

Logs said error: pathspec 'update-prod-pkg' did not match any file(s) known to gitwhen it run git checkout update-prod-pkg

@cb1kenobi
Copy link
Contributor

Running tests here: #10763

@martinez-hugo
Copy link
Author

Running tests here: #10763

I think now it’s deployment on vercel that’s blocking checks
Do you have visibility on deployment logs ?

@martinez-hugo
Copy link
Author

martinez-hugo commented Oct 24, 2023

Nice it works for deployment @cb1kenobi @Ethan-Arrowood @TooTallNate so I think that Tests will pass now if we relaunch it

@cb1kenobi
Copy link
Contributor

@martinez-hugo we are experiencing degraded performance and will re-run the tests as soon as the system returns back to normal.

@martinez-hugo
Copy link
Author

@cb1kenobi @TooTallNate @Ethan-Arrowood I just sync branch with main branch

@martinez-hugo
Copy link
Author

I don’t understand how these errors can exists. Because I just update vercel/node, not vercel core

@Ethan-Arrowood
Copy link
Contributor

Ethan-Arrowood commented Oct 24, 2023

It's not you, its us lol! Our dev server implementation is broken by the recent Undici update. This is okay, we were using fetch someplace we shouldn't have been. This PR: #10767 fixes it but will take a moment to land. I'd like to add you as a co-commit-author on the update undici commit. What is your preferred git user name and email address (something like Co-authored-by: Ethan Arrowood <ethan.arrowood@vercel.com>)

@martinez-hugo
Copy link
Author

It's not you, its us lol! Our dev server implementation is broken by the recent Undici update. This is okay, we were using fetch someplace we shouldn't have been. This PR: #10767 fixes it but will take a moment to land. I'd like to add you as a co-commit-author on the update undici commit. What is your preferred git user name and email address (something like Co-authored-by: Ethan Arrowood <ethan.arrowood@vercel.com>)

Thanks for all Ethan.
Can I help on anything on this fix ?
This is my good informations : Hugo Martinez contact@hmartinez.fr

@Ethan-Arrowood
Copy link
Contributor

Thank you again for bringing this to our attention! We've released version 32.5.3 which contains the undici dependency upgrade as well as the necessary fix for the update. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants