fix: Ensure useSWRImmutable overrides global refreshInterval#4208
Merged
shuding merged 3 commits intovercel:mainfrom Jan 19, 2026
Merged
fix: Ensure useSWRImmutable overrides global refreshInterval#4208shuding merged 3 commits intovercel:mainfrom
shuding merged 3 commits intovercel:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
|
Makes sense but could you remove the comment and put the test inside the immutable test suite? Thanks. |
Contributor
Author
|
@shuding Thanks for the review! Removed the inline comments in the source code. Moved the reproduction test case into the main suite (test/use-swr-immutable.test.tsx). Deleted the standalone test file. Verified all tests pass locally. Ready for re-evaluation! |
shuding
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4207
The Bug:
Previously,
useSWRImmutabledid not explicitly disablerefreshInterval. If a user set a globalrefreshIntervalinSWRConfig, the immutable hook would inherit this configuration and revalidate repeatedly, violating the "immutable" behavior.The Fix:
I updated the
immutablemiddleware to explicitly enforcerefreshInterval = 0. This ensures that even if a global polling interval is set,useSWRImmutablewill correctly ignore it.Verification
I added a reproduction test case in
test/issue-4207.test.tsx.useSWRImmutable).Ran full test suite (
pnpm test) to ensure no regressions.