fix: Replace the deprecated 'window' with 'globalThis' for Deno#2915
Merged
huozhi merged 1 commit intovercel:mainfrom Mar 18, 2024
Merged
fix: Replace the deprecated 'window' with 'globalThis' for Deno#2915huozhi merged 1 commit intovercel:mainfrom
huozhi merged 1 commit intovercel:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
huozhi
approved these changes
Mar 18, 2024
Member
|
Thanks! good to hear |
|
globalThis is not defined：globalThis 在一些低版本的浏览器上并不兼容 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
windowobject became deprecated in Deno (denoland/deno#22057). Instead, they recommend us to useglobalThisorself. For the change, I also referred to here (https://deno.land/x/udibo_react_app@0.3.3/env.ts?source=#L7)