Skip to content

Use GitHub Actions to run tests and publish#186

Merged
AndyBitz merged 6 commits intomasterfrom
use-github-actions
Nov 1, 2022
Merged

Use GitHub Actions to run tests and publish#186
AndyBitz merged 6 commits intomasterfrom
use-github-actions

Conversation

@AndyBitz
Copy link
Copy Markdown
Contributor

@AndyBitz AndyBitz commented Nov 1, 2022

  • Moves to GitHub Actions for tests and publishing to be more aligned with our other repos.
  • Replaces the Codecov dependency with its GitHub Action.

Will remove Circle and change the required action once this PR got approved.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 1, 2022

Codecov Report

Merging #186 (df1a486) into master (1237cd6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #186   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          342       342           
=========================================
  Hits           342       342           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AndyBitz AndyBitz marked this pull request as ready for review November 1, 2022 18:55
push:
branches: [master]
pull_request:
branches: [master]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow up PR, lets change the branch to main

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yes, planned on doing that!


on:
release:
types: [created]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this get invoked? Do we need to run npm version somewhere?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, when a new release gets created on https://github.com/vercel/serve-handler/releases

So, we'd continue to run e.g. release to create a new version + update package.json + prepare the release. And once the release gets published/created, that action would run.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so there will still be a manual process and committing/pushing to main directly.

In the future, we might want to automate that part too 👍

Copy link
Copy Markdown
Contributor

@kachkaev kachkaev Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re using changesets/changesets in blockprotocol/blockprotocol, it works pretty well for managing changelogs & releases on GitHub!

Copy link
Copy Markdown
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndyBitz AndyBitz merged commit 6ba5e33 into master Nov 1, 2022
@AndyBitz AndyBitz deleted the use-github-actions branch November 1, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants