fix: add missing CLI option to argv parser#742
fix: add missing CLI option to argv parser#742AndyBitz merged 1 commit intovercel:mainfrom casperx:fix/broken-cli-option
Conversation
help message and types for the request logging option were updated, but the argument parser option wasn't.
|
I was going to open the same PR right now, then I saw it was already open :) |
gamemaker1
left a comment
There was a problem hiding this comment.
This looks good to me, could someone please merge it?
|
Can we get this merge please? |
|
Issue #744 is holding back our project. Would appreciate if this PR can be reviewed/approved soon. Thanks. |
|
@rohan-kadkol my temporary fork here: https://www.npmjs.com/package/jsbrain_serve ... not sure about your compliance though if you try to deploy to production. |
@rohan-kadkol you can probably use https://www.npmjs.com/package/patch-package and apply @casperx 's fix to get you unblocked |
AndyBitz
left a comment
There was a problem hiding this comment.
Thank you for the PR! I'll create a release with it asap
help message and types for the request logging option were updated, but the argument parser option wasn't. When the user specifies
-L,--no-request-loggingas specified in the help message, argument parser throwsArgError: unknown or unexpected option.