Conversation
|
Changes in this PR will be automatically deployed with Now. This message will be updated over time. |
timneutkens
approved these changes
May 28, 2018
|
I can hear the servers worldwide crying:
Our company has something like 20 separate frontend apps that all broke on this merge. Time to go fix them 1-by-1. Perhaps there's an announcement system to the For reference, our command which now fails was " |
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces serve-handler as the core of
serve.This is removing several command line flags (which were bloating the project), but also adding support for many more configuration options.
As a result, it makes
servemore powerful, faster and more lean than ever before.NOTE: This is a fresh start. As mentioned above, a lot of features have been removed for which we couldn't find any reason to keep them as part of the core.
Once this is out, we'll re-evaluate every suggestion and see whether it makes sense to include it in serve itself, or if it makes more sense to just drop serve-handler into a 3-line
.jsfile with micro in it and then add another middleware for the feature that you're looking for.