Ensure serve starts even when update check fails#360
Merged
Conversation
leo
approved these changes
May 14, 2018
Contributor
|
Looks wonderful. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
servefor our e2e tests and after upgrading recently noticed CI failures because of the update check that happens before starting the server. We are sitting behind a corporate proxy and theupdate-checkmodule does not seem to respect the proxy environment variables.After around 30 seconds
connectthrows aETIMEDOUTexception that is not being handled and thus the server does not start.This pull request catches errors occuring in update check to ensure
serveis started even when the update check fails. Additionally it adds a timeout to the update check call to wait no more than 2 seconds for it to complete.Before:
After:
