Skip to content

fix(devtools): detect VSCodium on macOS in launch-editor#94078

Draft
pipe1os wants to merge 2 commits into
vercel:canaryfrom
pipe1os:fix/vscodium-macos-detection
Draft

fix(devtools): detect VSCodium on macOS in launch-editor#94078
pipe1os wants to merge 2 commits into
vercel:canaryfrom
pipe1os:fix/vscodium-macos-detection

Conversation

@pipe1os

@pipe1os pipe1os commented May 24, 2026

Copy link
Copy Markdown

What?

Fixes an issue where the Next.js error overlay fails to open VSCodium on macOS.

Why?

  1. VSCodium renamed its macOS binary from Electron to VSCodium. COMMON_EDITORS_MACOS was only checking for the old path, causing guessEditor() to fail silently.
  2. Even if launched, the editor basename codium was missing from the switch statement in getArgumentsForLineNumber, causing it to drop the line and column targeting arguments.

How?

  • Added the updated VSCodium macOS binary path to COMMON_EDITORS_MACOS (and updated the legacy Electron mapping to point to codium).
  • Added case 'codium': to the VS Code family block in getArgumentsForLineNumber.
  • Exported the utility functions to author isolated Jest tests verifying the macOS fallback logic.

Testing Status:

  • ✅ Unit tests passed locally.
  • ✅ Added launch-editor.test.ts to strictly cover the codium mapping and macOS execution paths.
  • ⚠️ Needs macOS Verification: I am submitting this from a Linux environment. While the unit tests pass, I am opening this as a draft so a maintainer or community member on macOS can pull this branch and verify the physical editor launch from the browser overlay before merging.

Fixes #94077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSCodium not detected on macOS when clicking error overlay links

1 participant