fix(devtools): detect VSCodium on macOS in launch-editor#94078
Draft
pipe1os wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue where the Next.js error overlay fails to open VSCodium on macOS.
Why?
ElectrontoVSCodium.COMMON_EDITORS_MACOSwas only checking for the old path, causingguessEditor()to fail silently.codiumwas missing from theswitchstatement ingetArgumentsForLineNumber, causing it to drop the line and column targeting arguments.How?
VSCodiummacOS binary path toCOMMON_EDITORS_MACOS(and updated the legacyElectronmapping to point tocodium).case 'codium':to the VS Code family block ingetArgumentsForLineNumber.Testing Status:
launch-editor.test.tsto strictly cover thecodiummapping and macOS execution paths.Fixes #94077