Skip to content

Revert "[test] Skip flaky cached-navigations tests"#93798

Merged
lubieowoce merged 2 commits into
canaryfrom
revert-92199-sebbie/04-01-_test_skip_flaky_cached-navigations_tests
May 13, 2026
Merged

Revert "[test] Skip flaky cached-navigations tests"#93798
lubieowoce merged 2 commits into
canaryfrom
revert-92199-sebbie/04-01-_test_skip_flaky_cached-navigations_tests

Conversation

@unstubbable

@unstubbable unstubbable commented May 12, 2026

Copy link
Copy Markdown
Contributor

Reverts #92199.

Depends on #93802, which patches playwright-core to fix the root cause: the client-side Response._finishedPromise was never resolved on requestFailed, causing response.finished() to hang indefinitely and surface as opaque 60s Jest timeouts in router-act-using tests.

With that patch in place, the cached-navigations tests can be reinstated. This PR's CI is part of the verification path — the previously-flaky tests now run cleanly through the 3× flake-detection job.

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 0251ced

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 810ms 810ms █████
Cold (Ready in log) 784ms 782ms ▆▅▆█▅
Cold (First Request) 1.211s 1.211s ▁▃▅█▁
Warm (Listen) 810ms 810ms ▃▇▁▅▅
Warm (Ready in log) 781ms 783ms ▂▂▃▅▁
Warm (First Request) 595ms 598ms ▃▂▃▅▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 812ms 811ms ▆█▃▃▃
Cold (Ready in log) 786ms 789ms █▃▁▇▇
Cold (First Request) 3.209s 3.220s █▂▁▅▆
Warm (Listen) 811ms 811ms ▅▅▃▃▅
Warm (Ready in log) 787ms 788ms ▆▂▁▇▆
Warm (First Request) 3.235s 3.231s ▇▂▁▅▇

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.664s 4.734s ▂▄▄▃▃
Cached Build 4.697s 4.725s ▁▃▂▅▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 24.081s 23.875s █▇▃▇▆
Cached Build 24.154s 23.825s ██▁▆█
node_modules Size 506 MB 506 MB █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
04hm05ar7kldw.js gzip 5.73 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB
0dvitrl5zg37g.js gzip 8.82 kB N/A -
0sf7ysou-72zd.js gzip 8.71 kB N/A -
13hp7a8nabpph.js gzip 160 B N/A -
157abun3hwc_s.js gzip 10.3 kB N/A -
189drjxvd_ara.js gzip 151 B N/A -
1elt1qium-r2m.css gzip 115 B 115 B
1emtlsxh55saq.js gzip 156 B N/A -
1jj68jv9537mc.js gzip 13.8 kB N/A -
1jpaub6y8xlfr.js gzip 2.3 kB N/A -
1ot0mvscrc_uf.js gzip 233 B N/A -
1u4z-8vtf7423.js gzip 156 B N/A -
1v1_5f5o4okrx.js gzip 156 B N/A -
2_m3xv2uq3sjc.js gzip 1.46 kB N/A -
2-zwnlw5uui4h.js gzip 154 B N/A -
24y34mwgrkqp4.js gzip 8.78 kB N/A -
2c-fd4y1zozz8.js gzip 8.79 kB N/A -
2d7416h_xd36x.js gzip 8.71 kB N/A -
2extn3odmmem_.js gzip 12.9 kB N/A -
2fyhyy7niw9r6.js gzip 7.61 kB N/A -
2lyuhit6rn8fy.js gzip 9.44 kB N/A -
2pcgd_aqiiat5.js gzip 70.8 kB N/A -
2q0gr8wfr3jwl.js gzip 8.77 kB N/A -
2q224pr6t6lxs.js gzip 150 B N/A -
2t9e75oz6r0zp.js gzip 8.76 kB N/A -
2uku_olcn15b7.js gzip 8.79 kB N/A -
30r8mm-46bdqy.js gzip 220 B 220 B
33ltxwdtt291k.js gzip 160 B N/A -
3830nv998xh4k.js gzip 156 B N/A -
3dyld9d_xsqrn.js gzip 49.9 kB N/A -
3ej3-jpeu72k-.js gzip 154 B N/A -
3inab2jybr4k9.js gzip 450 B N/A -
3jkm5tdjvaf_q.js gzip 13.1 kB N/A -
3mt67agm5wp40.js gzip 10.6 kB N/A -
3rssl3skxqw0e.js gzip 65.6 kB N/A -
3saabek4kohwi.js gzip 10 kB N/A -
3yw6jm3cxfyra.js gzip 165 B N/A -
3z6o-0747nqms.js gzip 157 B N/A -
4189xmby9yu1p.js gzip 13.6 kB N/A -
42suxw9pkvyvg.js gzip 154 B N/A -
turbopack-0j..iuqy.js gzip 4.2 kB N/A -
turbopack-0m..8dfb.js gzip 4.2 kB N/A -
turbopack-1d.._m4a.js gzip 4.21 kB N/A -
turbopack-1d..xt5-.js gzip 4.2 kB N/A -
turbopack-1l..j_bn.js gzip 4.2 kB N/A -
turbopack-1q..nh1y.js gzip 4.2 kB N/A -
turbopack-1s..3v6b.js gzip 4.2 kB N/A -
turbopack-1v..9m4a.js gzip 4.2 kB N/A -
turbopack-1y..ywtc.js gzip 4.2 kB N/A -
turbopack-21..k7x-.js gzip 4.18 kB N/A -
turbopack-2j..2j5y.js gzip 4.2 kB N/A -
turbopack-2u..5c5s.js gzip 4.2 kB N/A -
turbopack-36..fk6e.js gzip 4.2 kB N/A -
turbopack-43..ebbm.js gzip 4.19 kB N/A -
0_i7nqgx23st7.js gzip N/A 10 kB -
04ecz5id4y-83.js gzip N/A 49.9 kB -
05e40c15cx1dd.js gzip N/A 7.61 kB -
06gjxxymo1fyh.js gzip N/A 155 B -
06puhytyxk31p.js gzip N/A 8.82 kB -
0ku8f6jqu2bqf.js gzip N/A 70.8 kB -
0m34gln_kt4fg.js gzip N/A 5.73 kB -
0p93wfky2uu5w.js gzip N/A 157 B -
134_hu95tlizi.js gzip N/A 155 B -
1g3q1ww01thnl.js gzip N/A 2.3 kB -
1hraqxuiymq6v.js gzip N/A 8.79 kB -
1l9un1sl77287.js gzip N/A 1.46 kB -
1tr4rv_xncc5l.js gzip N/A 157 B -
21-eavqb1k_36.js gzip N/A 13.9 kB -
2147zgtf14z-q.js gzip N/A 234 B -
21njcykb-zh7o.js gzip N/A 161 B -
23bz3xsg-5-1s.js gzip N/A 8.71 kB -
24cgay5i_hxbo.js gzip N/A 154 B -
27441mytv7pbm.js gzip N/A 9.43 kB -
2cjkwjgm1zcfs.js gzip N/A 8.71 kB -
2qpr2lso48yql.js gzip N/A 156 B -
2rarx_dw0y63l.js gzip N/A 153 B -
2scd8zaoyb8md.js gzip N/A 8.79 kB -
2st_qs6p_9us0.js gzip N/A 13.1 kB -
2zo2exm1d8qj1.js gzip N/A 13.6 kB -
312mq_8mkriok.js gzip N/A 156 B -
31jz96iin42s5.js gzip N/A 156 B -
3ehsq7o481snb.js gzip N/A 65.6 kB -
3hn75zuxly9az.js gzip N/A 10.3 kB -
3hqh7m128tvsn.js gzip N/A 8.77 kB -
3hqti_t-zy1x4.js gzip N/A 449 B -
3mnawenie1flm.js gzip N/A 8.76 kB -
3ubsozlu6zs38.js gzip N/A 10.6 kB -
3v_zh_vwexa4n.js gzip N/A 151 B -
41mf-x3mmsxae.js gzip N/A 12.9 kB -
42e_gn0ci04-o.js gzip N/A 168 B -
436k78wa2qok1.js gzip N/A 159 B -
43iwfqjnx1cy_.js gzip N/A 8.78 kB -
turbopack-04..88kd.js gzip N/A 4.2 kB -
turbopack-0c..f337.js gzip N/A 4.2 kB -
turbopack-0d..fsbc.js gzip N/A 4.2 kB -
turbopack-0f..dp0v.js gzip N/A 4.2 kB -
turbopack-0i..b2pl.js gzip N/A 4.2 kB -
turbopack-0q..tpb_.js gzip N/A 4.2 kB -
turbopack-0y..xt_6.js gzip N/A 4.2 kB -
turbopack-13..j7p5.js gzip N/A 4.2 kB -
turbopack-1g..yg50.js gzip N/A 4.2 kB -
turbopack-2o..y62b.js gzip N/A 4.2 kB -
turbopack-2v..k3md.js gzip N/A 4.2 kB -
turbopack-3c..bxd7.js gzip N/A 4.21 kB -
turbopack-3r..tjlu.js gzip N/A 4.18 kB -
turbopack-3w..fd4k.js gzip N/A 4.2 kB -
Total 468 kB 469 kB ⚠️ +88 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 717 B 715 B
Total 717 B 715 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 432 B 432 B
Total 432 B 432 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2258-HASH.js gzip 61.4 kB N/A -
2266-HASH.js gzip 4.69 kB N/A -
3317.HASH.js gzip 169 B N/A -
4866-HASH.js gzip 5.64 kB N/A -
9e302639-HASH.js gzip 62.7 kB N/A -
framework-HASH.js gzip 59.5 kB 59.5 kB
main-app-HASH.js gzip 255 B 255 B
main-HASH.js gzip 39.9 kB 39.9 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
175fd0fd-HASH.js gzip N/A 62.7 kB -
2596-HASH.js gzip N/A 5.63 kB -
34-HASH.js gzip N/A 61.3 kB -
5691.HASH.js gzip N/A 169 B -
9156-HASH.js gzip N/A 4.68 kB -
Total 236 kB 236 kB ✅ -100 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 181 B 182 B
css-HASH.js gzip 334 B 332 B
dynamic-HASH.js gzip 1.79 kB 1.81 kB
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 351 B 348 B
hooks-HASH.js gzip 385 B 384 B
image-HASH.js gzip 580 B 580 B
index-HASH.js gzip 257 B 259 B
link-HASH.js gzip 2.51 kB 2.52 kB
routerDirect..HASH.js gzip 318 B 319 B
script-HASH.js gzip 387 B 386 B
withRouter-HASH.js gzip 316 B 316 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.99 kB ⚠️ +19 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB
page.js gzip 275 kB 270 kB 🟢 5.31 kB (-2%)
Total 401 kB 396 kB ✅ -5.5 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 617 B
middleware-r..fest.js gzip 155 B 155 B
middleware.js gzip 44.4 kB 44.9 kB 🔴 +496 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B
Total 46 kB 46.5 kB ⚠️ +496 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 719 B 717 B
Total 719 B 717 B ✅ -2 B
Build Cache
Canary PR Change
0.pack gzip 4.48 MB 4.47 MB
index.pack gzip 114 kB 115 kB
index.pack.old gzip 112 kB 113 kB
Total 4.7 MB 4.7 MB ✅ -2.46 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 350 kB 350 kB
app-page-exp..prod.js gzip 194 kB 194 kB
app-page-tur...dev.js gzip 349 kB 349 kB
app-page-tur..prod.js gzip 194 kB 194 kB
app-page-tur...dev.js gzip 346 kB 346 kB
app-page-tur..prod.js gzip 192 kB 192 kB
app-page.run...dev.js gzip 346 kB 346 kB
app-page.run..prod.js gzip 192 kB 192 kB
app-route-ex...dev.js gzip 77.5 kB 77.5 kB
app-route-ex..prod.js gzip 52.9 kB 52.9 kB
app-route-tu...dev.js gzip 77.6 kB 77.6 kB
app-route-tu..prod.js gzip 52.9 kB 52.9 kB
app-route-tu...dev.js gzip 77.2 kB 77.2 kB
app-route-tu..prod.js gzip 52.7 kB 52.7 kB
app-route.ru...dev.js gzip 77.1 kB 77.1 kB
app-route.ru..prod.js gzip 52.7 kB 52.7 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 44.3 kB 44.3 kB
pages-api-tu..prod.js gzip 33.8 kB 33.8 kB
pages-api.ru...dev.js gzip 44.3 kB 44.3 kB
pages-api.ru..prod.js gzip 33.7 kB 33.7 kB
pages-turbo....dev.js gzip 53.7 kB 53.7 kB
pages-turbo...prod.js gzip 39.4 kB 39.4 kB
pages.runtim...dev.js gzip 53.6 kB 53.6 kB
pages.runtim..prod.js gzip 39.4 kB 39.4 kB
server.runti..prod.js gzip 63.1 kB 63.1 kB
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB
use-cache-pr...dev.js gzip 68 kB 68 kB
use-cache-pr...dev.js gzip 68 kB 68 kB
Total 3.37 MB 3.37 MB
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/0251cedf633c0e68f886ba984701ca8836150319/next

Commit: 0251ced

The client-side `BrowserContext._onRequestFailed` handler in
`playwright-core` does not resolve the corresponding
`Response._finishedPromise`, while `_onRequestFinished` does. When
Chromium fires `Network.loadingFailed` for a request that already
received a response — e.g. an RSC response that was delivered to the
response buffer but is no longer needed because a soft navigation has
already committed — the server-side `_finishedPromise` is resolved
correctly (in `chromium/crNetworkManager._onLoadingFailed`), but the
client side is never told. Any caller of `response.finished()` on
such a response hangs indefinitely, surfacing in tests as a 60s Jest
timeout with no clear stack trace.

This is the root cause of intermittent timeouts in router-act-using
tests.

The patch mirrors the resolve step from `_onRequestFinished`: look up
the response via the existing async `request.response()` RPC and
fire-and-forget `resolve(null)` on its `_finishedPromise`. `catch`
is a no-op so a tearing-down context doesn't produce an unhandled
rejection.

Verified empirically against workflow run
https://github.com/vercel/next.js/actions/runs/25760869258, which
flake-detected all 40 router-act consumers (each 3 times) with
diagnostic logging enabled. One `Network.loadingFailed canceled=true`
event fired during the run (the canonical bug scenario: an outer
`act` releasing a child `block: true` response that Chrome canceled
mid-flight; see
https://github.com/vercel/next.js/actions/runs/25760869258/job/75669131568)
— pre-patch this would have hung until Jest's 60s test timeout
fired, post-patch `response.finished()` resolved in 1ms. Alongside
~4000 normal resolutions, with zero `wait-browser-finished` hangs
and zero router-act-related test failures.

This is a stop-gap until the router-act rewrite in #90959 lands, which
replaces Playwright's `route.fulfill` + `response.finished()` flow
with a browser-side `fetch` interception and removes the dependency
on this Playwright code path entirely. The patch can be dropped at
that point.
@unstubbable unstubbable force-pushed the revert-92199-sebbie/04-01-_test_skip_flaky_cached-navigations_tests branch from cfe8e3a to 0251ced Compare May 12, 2026 22:02
@unstubbable unstubbable changed the base branch from canary to hl/playwright-finished-promise-patch May 12, 2026 22:03
@unstubbable unstubbable marked this pull request as ready for review May 12, 2026 22:32
@unstubbable unstubbable requested a review from acdlite May 12, 2026 22:37
lubieowoce
lubieowoce previously approved these changes May 13, 2026
Base automatically changed from hl/playwright-finished-promise-patch to canary May 13, 2026 11:46
@unstubbable unstubbable dismissed lubieowoce’s stale review May 13, 2026 11:46

The base branch was changed.

@lubieowoce lubieowoce merged commit 5d6a234 into canary May 13, 2026
165 checks passed
@lubieowoce lubieowoce deleted the revert-92199-sebbie/04-01-_test_skip_flaky_cached-navigations_tests branch May 13, 2026 11:48
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants