Fix cookie encode option support#93061
Open
afurm wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39ead5ed4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
39ead5e to
25315fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds support for custom cookie value encoders in Next.js response cookie serialization.
ResponseCookiesnow honors theencodeoption when serializingSet-Cookieheaders, while preservingencodeURIComponentas the default behavior. TheResponseCookietype also exposesencodesocookies().set()andNextResponse.cookies.set()can accept values like{ encode: String }.Why?
Users integrating with services that expect raw cookie values could not opt out of URL encoding. For example, setting a cookie value like
qwerty123=was serialized asqwerty123%3D, even when passingencode: String.Fixes #64346
How?
@edge-runtime/cookies@6.0.0sostringifyCookie()uses a providedencodefunction.@edge-runtime/cookiesoutput from the patched dependency.NextResponse.cookies.set(..., { encode: String })cookies().set()Tests