fix(turbopack): resolve build failure with multiple same-name app icons#89835
Draft
Apro-yuto wants to merge 1 commit intovercel:canaryfrom
Draft
fix(turbopack): resolve build failure with multiple same-name app icons#89835Apro-yuto wants to merge 1 commit intovercel:canaryfrom
Apro-yuto wants to merge 1 commit intovercel:canaryfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Include file extension in VirtualSource path for static metadata routes to prevent collisions when multiple icon files share the same stem (e.g.,
icon.pngandicon.svg).Why?
When an app directory contains multiple icon files with the same name but different extensions, Turbopack generates identical VirtualSource paths (
{stem}--route-entry.js), causing a build failure.How?
Changed the VirtualSource path format from
{stem}--route-entry.jsto{stem}.{ext}--route-entry.jsincrates/next-core/src/next_app/metadata/route.rs, making each path unique.Fixes #85496