Skip to content

[prebuilt-skew-protection] feat: adding in automatic deploymentId#88958

Merged
mischnic merged 18 commits intocanaryfrom
revert-88942-revert-88496-revert-88449-revert-88012-brooke/addAutomaticDeploymentId
Jan 27, 2026
Merged

[prebuilt-skew-protection] feat: adding in automatic deploymentId#88958
mischnic merged 18 commits intocanaryfrom
revert-88942-revert-88496-revert-88449-revert-88012-brooke/addAutomaticDeploymentId

Conversation

@brookemosby
Copy link
Contributor

@brookemosby brookemosby commented Jan 23, 2026 •
edited by mischnic
Loading

This feature is a requirement for prebuilt skew protection.
Currently when you deploy with prebuilt skew protection does not work, because there is no deployment id available to set in the environment.

This fixes that problem by:

  • Allows for a user configured deployment id to be set in config. This is then used for prebuilt skew protection id.
  • This id is written to routes-manifest.json so that builds can store this id to fetch by later.

@nextjs-bot nextjs-bot added Documentation Related to Next.js' official documentation. tests type: next labels Jan 23, 2026
@brookemosby brookemosby marked this pull request as draft January 23, 2026 15:40
@vercel
Copy link
Contributor

vercel bot commented Jan 23, 2026 •
edited
Loading

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 23, 2026 •
edited by brookemosby
Loading

Allow CI Workflow Run

  • approve CI run for commit: 8d68e8e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 23, 2026 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: 3e8d3a7

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

vercel[bot]
vercel bot reviewed Jan 23, 2026
View reviewed changes
@brookemosby brookemosby marked this pull request as ready for review January 23, 2026 19:07
mischnic
mischnic reviewed Jan 26, 2026
View reviewed changes
mischnic
mischnic reviewed Jan 26, 2026
View reviewed changes
mischnic
mischnic reviewed Jan 26, 2026
View reviewed changes
@brookemosby brookemosby requested a review from mischnic January 26, 2026 16:46
@mischnic mischnic added the CI approved Approve running CI for fork label Jan 27, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 27, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁█▁▁
Cold (Ready in log) 440ms 441ms ✓ █▆▂▁▇
Cold (First Request) 1.185s 1.175s ✓ █▆▁▁▇
Warm (Listen) 456ms 457ms ✓ ▁▁█▁▁
Warm (Ready in log) 443ms 446ms ✓ ▁▁▆▃▁
Warm (First Request) 343ms 342ms ✓ ▇▁▄▄▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 439ms 440ms ✓ ▁▄▂█▃
Cold (First Request) 1.860s 1.876s ✓ ▁▃▂█▃
Warm (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Warm (Ready in log) 440ms 439ms ✓ ▃▄▂█▄
Warm (First Request) 1.860s 1.920s ✓ ▁▃▂▇▄

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.364s 4.353s ✓ ▁▁▇▅▁
Cached Build 4.310s 4.261s ✓ ▁▁▅▄▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.100s 14.110s ✓ ▁▂▁▇▃
Cached Build 14.189s 14.232s ✓ ▁▁▁▄▂
node_modules Size 462 MB 462 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **432 kB** → **432 kB** ✅ -24 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 771 B 764 B ✓
Total 771 B 764 B ✅ -7 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 449 B 452 B ✓
Total 449 B 452 B ⚠️ +3 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 52.6 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 253 B ✓
main-HASH.js gzip 39 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.3 kB -
9544-HASH.js gzip N/A 53.1 kB -
Total 226 kB 226 kB ⚠️ +487 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 246 kB 247 kB ✓
Total 373 kB 373 kB ⚠️ +235 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 33.1 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 34.8 kB ⚠️ +78 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B ✓
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.71 MB 3.72 MB 🔴 +8.36 kB (+0%)
index.pack gzip 102 kB 102 kB ✓
index.pack.old gzip 101 kB 102 kB 🔴 +1.58 kB (+2%)
Total 3.92 MB 3.93 MB ⚠️ +9.91 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 308 kB 308 kB ✓
app-page-exp..prod.js gzip 164 kB 164 kB ✓
app-page-tur...dev.js gzip 308 kB 308 kB ✓
app-page-tur..prod.js gzip 164 kB 164 kB ✓
app-page-tur...dev.js gzip 305 kB 305 kB ✓
app-page-tur..prod.js gzip 162 kB 162 kB ✓
app-page.run...dev.js gzip 305 kB 305 kB ✓
app-page.run..prod.js gzip 162 kB 162 kB ✓
app-route-ex...dev.js gzip 70.2 kB 70.2 kB ✓
app-route-ex..prod.js gzip 48.8 kB 48.8 kB ✓
app-route-tu...dev.js gzip 70.2 kB 70.2 kB ✓
app-route-tu..prod.js gzip 48.8 kB 48.8 kB ✓
app-route-tu...dev.js gzip 69.8 kB 69.8 kB ✓
app-route-tu..prod.js gzip 48.6 kB 48.6 kB ✓
app-route.ru...dev.js gzip 69.7 kB 69.7 kB ✓
app-route.ru..prod.js gzip 48.6 kB 48.6 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api-tu..prod.js gzip 32.8 kB 32.8 kB ✓
pages-api.ru...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.4 kB 52.4 kB ✓
pages-turbo...prod.js gzip 39.3 kB 39.3 kB ✓
pages.runtim...dev.js gzip 52.3 kB 52.3 kB ✓
pages.runtim..prod.js gzip 39.3 kB 39.3 kB ✓
server.runti..prod.js gzip 62.5 kB 62.5 kB ✓
Total 2.75 MB 2.75 MB ✅ -2 B

@mischnic mischnic merged commit 1cbd83b into canary Jan 27, 2026
160 checks passed
@mischnic mischnic deleted the revert-88942-revert-88496-revert-88449-revert-88012-brooke/addAutomaticDeploymentId branch January 27, 2026 15:50
pieh
pieh reviewed Jan 28, 2026
View reviewed changes
packages/next/src/build/index.ts
Comment on lines +981 to +985
if (config.deploymentId.length > 32) {
throw new Error(
`Invalid \`deploymentId\` configuration: exceeds maximum length of 32 characters. See https://nextjs.org/docs/messages/deploymentid-too-long`
)
}
Copy link
Contributor

@pieh pieh Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brookemosby @mischnic can you provide some context on why this was added?

This hardcoded length limit breaks our setup and if this is mostly meant as "best practice" kind of nudge - could this be optionally disabled or made the limit configurable?

Copy link
Contributor Author

@brookemosby brookemosby Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing requirement here
#89173

@brookemosby brookemosby mentioned this pull request Jan 28, 2026
Merged
bgw pushed a commit that referenced this pull request Jan 28, 2026
@brookemosby
[nextjs] feat: removing length requirement (#89173)
82ad0dd 
Not a hard requirement so removing in [response to
request](#88958 (comment))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@mischnic mischnic mischnic approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

+1 more reviewer

@pieh pieh pieh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI approved Approve running CI for fork Documentation Related to Next.js' official documentation. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brookemosby @nextjs-bot @pieh @mischnic