fix: make RedirectType constant properties literal types#88653
Merged
ztanner merged 3 commits intovercel:canaryfrom Jan 16, 2026
Merged
fix: make RedirectType constant properties literal types#88653ztanner merged 3 commits intovercel:canaryfrom
ztanner merged 3 commits intovercel:canaryfrom
Conversation
- Changed from property-level `as const` to object-level `as const` for cleaner syntax - Added test coverage to ensure RedirectType.push and RedirectType.replace are properly typed as literal types when used with redirect()
ztanner
approved these changes
Jan 16, 2026
Member
ztanner
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've also added a test.
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixed TypeScript error where
RedirectType.replaceandRedirectType.pushwere typed asstringinstead of literal types, causing compilation errors when used withredirect().Why?
RedirectTypeconstant properties weren't properly typed as literal types, causing TypeScript to see them as genericstringvalues instead of the expected'push' | 'replace'union.How?
as consttoRedirectTypeproperties inpackages/next/src/client/components/navigation.react-server.ts.Fixes #88627