Skip to content

Fix optional parent_task_id compile failure w/tokio_tracing enabled#88598

Merged
mischnic merged 1 commit intocanaryfrom
mmastrac/fix-tokio-tracing-parent-task
Jan 15, 2026
Merged

Fix optional parent_task_id compile failure w/tokio_tracing enabled#88598
mischnic merged 1 commit intocanaryfrom
mmastrac/fix-tokio-tracing-parent-task

Conversation

@mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Jan 15, 2026

What

This was causing an error when the tokio_tracing feature was enabled because parent_task_id is an option:

        #[cfg(feature = "tokio_tracing")]
        let description = format!(
            "[local] (parent: {}) {}",
            self.backend.get_task_description(parent_task_id),
            ty.task_type,
        );

How

Reworks this to be valid code using map + debug output.

@mmastrac
Fix tokio_tracing for optional parent_task_id
1c2eca1 
Handle parent_task_id as Option type in the tokio_tracing feature code path.
@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 15, 2026
@mmastrac mmastrac changed the title Fix tokio_tracing for optional parent_task_id Fix optional parent_task_id compile failure w/tokio_tracing enabled Jan 15, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 15, 2026 •
edited by mmastrac
Loading

Allow CI Workflow Run

  • approve CI run for commit: 1c2eca1

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 15, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ █▁█▁▁
Cold (Ready in log) 439ms 438ms ✓ ▆▆█▆▆
Cold (First Request) 1.127s 1.159s ✓ ▄▇█▇█
Warm (Listen) 457ms 457ms ✓ █▁▅▁▁
Warm (Ready in log) 443ms 443ms ✓ █▁▃▁▁
Warm (First Request) 346ms 343ms ✓ █▂▆▁▆
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ █▁▁▁▁
Cold (Ready in log) 440ms 439ms ✓ ▆▅▄▅▄
Cold (First Request) 1.776s 1.777s ✓ ▄▃▂▃▂
Warm (Listen) 456ms 455ms ✓ █▁▁▁▁
Warm (Ready in log) 440ms 440ms ✓ ▆▅▃▄▅
Warm (First Request) 1.769s 1.778s ✓ ▄▃▂▂▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.059s 4.051s ✓ █▁▄▁▂
Cached Build 4.063s 4.062s ✓ █▁▄▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.135s 14.078s ✓ ▃▁▁▁▁
Cached Build 14.230s 14.260s ✓ ▄▁▁▁▁
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ✅ -86 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 788 B 787 B ✓
Total 788 B 787 B ✅ -1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.3 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 253 B ✓
main-HASH.js gzip 38.6 kB 38.9 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 51.9 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ✅ -12 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 237 kB 🟢 4.88 kB (-2%)
Total 366 kB 361 kB ✅ -4.87 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 655 B 652 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 32.9 kB 33.3 kB 🔴 +375 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.6 kB 34.9 kB ⚠️ +373 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.67 MB 🔴 +4.94 kB (+0%)
index.pack gzip 99.3 kB 100 kB ✓
index.pack.old gzip 99.9 kB 99.6 kB ✓
Total 3.86 MB 3.87 MB ⚠️ +5.43 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 303 kB 303 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 303 kB 303 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 300 kB 300 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ⚠️ +8 B

@mischnic mischnic merged commit 8e5146f into canary Jan 15, 2026
214 of 237 checks passed
@mischnic mischnic deleted the mmastrac/fix-tokio-tracing-parent-task branch January 15, 2026 18:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mischnic mischnic mischnic approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmastrac @nextjs-bot @mischnic