Skip to content

[scripts] Avoid conflicting type for pack-next --compress #88439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
unstubbable merged 1 commit into from
Jan 12, 2026
Merged

[scripts] Avoid conflicting type for pack-next --compress #88439

unstubbable merged 1 commit into from
Jan 12, 2026
+7 −14

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 12, 2026

type: 'string' conflicts with choices: T[]. It's basically string | T which just collapses to string if T is a union of string literals.

Before:

$ p pack-next --help
...
 --compress ... [string] [choices: "none", "strip"]

After:

$ p pack-next --help
...
 --compress ... [choices: "none", "strip"]

@eps1lon eps1lon requested a review from unstubbable January 12, 2026 19:04
@nextjs-bot nextjs-bot added the created-by: Next.js team PRs by the Next.js team. label Jan 12, 2026
@eps1lon eps1lon mentioned this pull request Jan 12, 2026
Merged
unstubbable
unstubbable approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@unstubbable unstubbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ✓ ▁▁▁▁▁
Cold (Ready in log) 438ms 438ms ✓ █▇█▁▁
Cold (First Request) 1.123s 1.122s ✓ ▇██▁▁
Warm (Listen) 457ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 441ms 441ms ✓ ▁▁▂▂▁
Warm (First Request) 340ms 338ms ✓ ▂▂▆▄▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▅▁▁▁▁
Cold (Ready in log) 435ms 436ms ✓ ▆▇█▆▆
Cold (First Request) 1.733s 1.747s ✓ ▅▆▅▄▅
Warm (Listen) 457ms 456ms ✓ █████
Warm (Ready in log) 435ms 436ms ✓ ██▇██
Warm (First Request) 1.753s 1.758s ✓ ▅▇▅▅▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.123s 4.132s ✓ ▁▁▁▂▂
Cached Build 4.088s 4.101s ✓ ▁▁▂▂▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.916s 13.880s ✓ ▁▃▁▁▁
Cached Build 14.048s 14.040s ✓ ▁▃▁▁▁
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ✅ -16 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 787 B 791 B ✓
Total 787 B 791 B ⚠️ +4 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 250 B 253 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +245 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 242 kB ✓
Total 367 kB 367 kB ⚠️ +411 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 656 B 653 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.2 kB 33.3 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.8 kB 34.9 kB ⚠️ +139 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.67 MB 3.67 MB ✓
index.pack gzip 99.7 kB 99.8 kB ✓
index.pack.old gzip 99.7 kB 99.1 kB ✓
Total 3.87 MB 3.87 MB ⚠️ +2.54 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 301 kB 301 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.9 kB 50.9 kB ✓
pages-turbo...prod.js gzip 38.3 kB 38.3 kB ✓
pages.runtim...dev.js gzip 50.8 kB 50.8 kB ✓
pages.runtim..prod.js gzip 38.3 kB 38.3 kB ✓
server.runti..prod.js gzip 62.3 kB 62.3 kB ✓
Total 2.69 MB 2.69 MB ⚠️ +2 B
📝 Changed Files (2 files)

Files with changes:

  • pages-api.ru..time.prod.js
  • pages.runtime.prod.js
View diffs
pages-api.ru..time.prod.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

@unstubbable unstubbable enabled auto-merge (squash) January 12, 2026 20:10
@unstubbable unstubbable merged commit 0fd7d90 into canary Jan 12, 2026
285 of 287 checks passed
@unstubbable unstubbable deleted the sebbie/01-12-_scripts_avoid_conflicting_type_for_pack-next_--compress_ branch January 12, 2026 20:18
eps1lon
eps1lon commented Jan 12, 2026
View reviewed changes
scripts/pack-next.ts
Comment on lines +53 to 56
...(process.platform === 'linux'
? (['objcopy-zlib', 'objcopy-zstd'] as const)
: ([] as const)),
] as const,
Copy link
Member Author

@eps1lon eps1lon Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revolver ocelot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unstubbable unstubbable unstubbable approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eps1lon @nextjs-bot @unstubbable