Skip to content

Revert "refactor: consolidate PPR into cacheComponents architecture (#88243)" #88421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
unstubbable merged 1 commit into from
Jan 12, 2026
Merged

Revert "refactor: consolidate PPR into cacheComponents architecture (#88243)" #88421

unstubbable merged 1 commit into from
Jan 12, 2026

Conversation

@unstubbable
Copy link
Contributor

@unstubbable unstubbable commented Jan 12, 2026

This reverts commit a85d888.

PR #88243 introduced deploy test regressions in the following test suites:

  • test/e2e/app-dir/segment-cache/prefetch-runtime/prefetch-runtime.test.ts
  • test/e2e/app-dir/segment-cache/client-params/client-params.test.ts

@unstubbable
Revert "refactor: consolidate PPR into cacheComponents architecture (#…
3af894f 
…88243)"

This reverts commit a85d888.

PR #88243 introduced deploy test regressions in the following test
suites:

- `test/e2e/app-dir/segment-cache/prefetch-runtime/prefetch-runtime.test.ts`
- `test/e2e/app-dir/segment-cache/client-params/client-params.test.ts`
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 457 MB 458 MB 🔴 +939 kB (+0%) █████
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁█▁▁▁
Cold (Ready in log) 434ms 435ms ✓ █▂▇▇▆
Cold (First Request) 1.166s 1.110s ✓ █▂▇██
Warm (Listen) 456ms 457ms ✓ ▆▃▆▃▃
Warm (Ready in log) 438ms 443ms ✓ ▁█▁▁▄
Warm (First Request) 337ms 331ms ✓ ▆██▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ █████
Cold (Ready in log) 434ms 433ms ✓ ▁▂█▅▄
Cold (First Request) 1.818s 1.816s ✓ ▄▄█▄▄
Warm (Listen) 455ms 456ms ✓ ▅▅▅▅▁
Warm (Ready in log) 435ms 434ms ✓ ▇▁▅▅▅
Warm (First Request) 1.819s 1.815s ✓ ▆▄█▅▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.029s 4.033s ✓ ▁█▁▁▂
Cached Build 4.056s 3.993s ✓ ▁█▁▂▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.828s 13.832s ✓ ▂▂█▁▂
Cached Build 13.978s 13.972s ✓ ▂▁█▁▂
node_modules Size 457 MB 458 MB 🔴 +939 kB (+0%) █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **431 kB** ⚠️ +548 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 788 B 787 B ✓
Total 788 B 787 B ✅ -1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +244 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 239 kB 242 kB 🔴 +2.47 kB (+1%)
Total 364 kB 367 kB ⚠️ +2.5 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 652 B 651 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 32.9 kB 33.2 kB 🔴 +378 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.5 kB 34.9 kB ⚠️ +378 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.62 MB 3.66 MB 🔴 +39.1 kB (+1%)
index.pack gzip 100 kB 99.9 kB ✓
index.pack.old gzip 99.6 kB 99.4 kB ✓
Total 3.82 MB 3.85 MB ⚠️ +38.7 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 303 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 303 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 299 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 300 kB 300 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.2 kB 68.7 kB ✓
app-route-ex..prod.js gzip 46.9 kB 47.5 kB 🔴 +629 B (+1%)
app-route-tu...dev.js gzip 68.2 kB 68.8 kB ✓
app-route-tu..prod.js gzip 46.9 kB 47.6 kB 🔴 +630 B (+1%)
app-route-tu...dev.js gzip 67.8 kB 68.4 kB ✓
app-route-tu..prod.js gzip 46.7 kB 47.3 kB 🔴 +632 B (+1%)
app-route.ru...dev.js gzip 67.8 kB 68.3 kB ✓
app-route.ru..prod.js gzip 46.7 kB 47.3 kB 🔴 +631 B (+1%)
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api-tu..prod.js gzip 31.2 kB 31.2 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.8 kB 50.8 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62 kB 62.2 kB ✓
Total 2.68 MB 2.69 MB ⚠️ +11.2 kB
📝 Changed Files (17 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • server.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js 
failed to diff
app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js 
failed to diff
app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

@unstubbable unstubbable marked this pull request as ready for review January 12, 2026 12:30
@vercel
Copy link
Contributor

vercel bot commented Jan 12, 2026 •
edited
Loading

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

@unstubbable unstubbable requested a review from eps1lon January 12, 2026 12:31
@unstubbable unstubbable changed the title Revert "refactor: consolidate PPR into cacheComponents architecture (#88243) Revert "refactor: consolidate PPR into cacheComponents architecture (#88243)" Jan 12, 2026
@unstubbable unstubbable merged commit 9c5e3da into canary Jan 12, 2026
160 of 161 checks passed
@unstubbable unstubbable deleted the hl/revert-88243 branch January 12, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@unstubbable @nextjs-bot @eps1lon