[backport] NFT tracing fixes #84155 and #85323 by mischnic · Pull Request #88124 · vercel/next.js

mischnic · 2026-01-05T20:50:41Z

Doing this in a single PR because the second followup PR touches the exact same lines as the first one, so you can't revert these individually anyway.

nextjs-bot · 2026-01-05T20:51:02Z

Allow CI Workflow Run

approve CI run for commit: 2bf16e0

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

codspeed-hq · 2026-01-05T21:16:04Z

CodSpeed Performance Report

Merging this PR will degrade performance by 20.02%

_{Comparing mischnic/backport-84155-85323 (61fbff8) with canary (02d8ff2)¹}

Summary

⚡ 1 improved benchmark
❌ 8 regressed benchmarks
⏩ 8 skipped benchmarks²

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`build[date-fns-all]`	2.1 s	2.3 s	-8.32%
❌	Simulation	`build[lucide-react-all]`	7.4 s	9.2 s	-20.02%
❌	Simulation	`build[framer-motion-single]`	2.1 s	2.3 s	-8.88%
❌	Simulation	`build[framer-motion-all]`	2.8 s	3.2 s	-12.94%
❌	Simulation	`build[joy]`	2 s	2.1 s	-7.31%
❌	Simulation	`build[shiki]`	5.2 s	6.1 s	-15.16%
❌	Simulation	`build[mui]`	2.9 s	3.3 s	-11.03%
⚡	Simulation	`build[lucide-react-single]`	957.5 ms	911 ms	+5.11%
❌	Simulation	`build[date-fns-single]`	1.3 s	1.4 s	-3.21%

No successful run was found on next-15-5 (ce36aec) during the generation of this report, so canary (02d8ff2) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

nextjs-bot · 2026-01-28T09:40:27Z

Failing test suites

Commit: 417eb2a | About building and testing Next.js

pnpm test packages/next-codemod/transforms/__tests__/app-dir-runtime-config-experimental-edge.test.js (job)

app-dir-runtime-config-experimental-edge > transforms correctly using "app-dir-runtime-config-experimental-edge/basic" data (DD)

Expand output

● app-dir-runtime-config-experimental-edge › transforms correctly using "app-dir-runtime-config-experimental-edge/basic" data

expect(received).toEqual(expected) // deep equality

- Expected  - 3
+ Received  + 3

- export const runtime = "edge";
+ export const runtime = "edge";
- export default function Page() {
+ export default function Page() {
-   return <div>hello world</div>;
+   return <div>hello world</div>;
  }

  at runInlineTest (../node_modules/.pnpm/jscodeshift@17.0.0_@babel+preset-env@7.26.9_@babel+core@7.26.10_/node_modules/jscodeshift/dist/testUtils.js:49:18)
  at runTest (../node_modules/.pnpm/jscodeshift@17.0.0_@babel+preset-env@7.26.9_@babel+core@7.26.10_/node_modules/jscodeshift/dist/testUtils.js:98:3)
  at Object.<anonymous> (../node_modules/.pnpm/jscodeshift@17.0.0_@babel+preset-env@7.26.9_@babel+core@7.26.10_/node_modules/jscodeshift/dist/testUtils.js:115:7)

pnpm test packages/next-codemod/transforms/__tests__/built-in-next-font.test.js (job)

built-in-next-font > transforms correctly using "built-in-next-font/page" data (DD)

Expand output

● built-in-next-font › transforms correctly using "built-in-next-font/page" data

expect(received).toEqual(expected) // deep equality

- Expected  - 29
+ Received  + 29

- // @ts-nocheck
+ // @ts-nocheck
- /* eslint-disable */
+ /* eslint-disable */
- import { Oswald } from "next/font/google";
+ import { Oswald } from "next/font/google";
- import localFont1 from "next/font/local";
+ import localFont1 from "next/font/local";
- import type { AdjustFontFallback } from "next/font"
-
+ import type { AdjustFontFallback } from "next/font"
+ 
- const oswald = Oswald({ subsets: ["latin"] });
+ const oswald = Oswald({ subsets: ["latin"] });
- const myFont = localFont1({
+ const myFont = localFont1({
-   src: "./my-font.woff2",
+   src: "./my-font.woff2",
- });
-
+ });
+ 
- import { Inter } from "next/font/google";
+ import { Inter } from "next/font/google";
- import localFont2 from "next/font/local";
-
+ import localFont2 from "next/font/local";
+ 
- const inter = Inter({ subsets: ["latin"] });
+ const inter = Inter({ subsets: ["latin"] });
- const myOtherFont = localFont2({
+ const myOtherFont = localFont2({
-   src: "./my-other-font.woff2",
+   src: "./my-other-font.woff2",
- });
-
+ });
+ 
- export default function WithFonts() {
+ export default function WithFonts() {
-   return (
+   return (
-     <>
+     <>
-       <p className={oswald.className}>oswald</p>
+       <p className={oswald.className}>oswald</p>
-       <p className={myFont.className}>myFont</p>
-
+       <p className={myFont.className}>myFont</p>
+ 
-       <p className={inter.className}>inter</p>
+       <p className={inter.className}>inter</p>
-       <p className={myOtherFont.className}>myOtherFont</p>
+       <p className={myOtherFont.className}>myOtherFont</p>
-     </>
+     </>
-   );
+   );
  }

  at runInlineTest (../node_modules/.pnpm/jscodeshift@17.0.0_@babel+preset-env@7.26.9_@babel+core@7.26.10_/node_modules/jscodeshift/dist/testUtils.js:49:18)
  at runTest (../node_modules/.pnpm/jscodeshift@17.0.0_@babel+preset-env@7.26.9_@babel+core@7.26.10_/node_modules/jscodeshift/dist/testUtils.js:98:3)
  at Object.<anonymous> (../node_modules/.pnpm/jscodeshift@17.0.0_@babel+preset-env@7.26.9_@babel+core@7.26.10_/node_modules/jscodeshift/dist/testUtils.js:115:7)

Tests are missing Previously, `readFileSync("./data/foo.txt")` was relative to the current file, not relative to `process.cwd()`

The `.contains("/node_modules/")` condition didn't work for npm, where the path might be `"node_modules/.prisma/client"` This fixes cases of the following error with Prisma and npm ``` Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x". We detected that you are using Next.js, learn how to fix this: https://pris.ly/d/engine-not-found-nextjs. This is likely caused by tooling that has not copied "libquery_engine-rhel-openssl-3.0.x.so.node" to the deployment folder. Ensure that you ran `prisma generate` and that "libquery_engine-rhel-openssl-3.0.x.so.node" has been copied to "node_modules/.prisma/client". We would appreciate if you could take the time to share some information with us. Please help us by answering a few questions: https://pris.ly/engine-not-found-tooling-investigation The following locations have been searched: /var/task/node_modules/.prisma/client /var/task/node_modules/@prisma/client /vercel/path0/node_modules/@prisma/client /tmp/prisma-engines ```

nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js. labels Jan 5, 2026

mischnic mentioned this pull request Jan 5, 2026

[backport] Turbopack: validate CSS without computing all paths (#83810) #88125

Merged

mischnic requested a review from a team January 5, 2026 21:28

bgw approved these changes Jan 8, 2026

View reviewed changes

mischnic force-pushed the mischnic/backport-83810 branch from 4622122 to aaa5ac9 Compare January 28, 2026 08:46

mischnic force-pushed the mischnic/backport-84155-85323 branch 2 times, most recently from 07745be to 417eb2a Compare January 28, 2026 08:47

Base automatically changed from mischnic/backport-83810 to next-15-5 January 28, 2026 09:58

mischnic added 2 commits January 28, 2026 10:58

Turbopack: fix NFT of readFileSync of relative path (#84155)

792685c

Tests are missing Previously, `readFileSync("./data/foo.txt")` was relative to the current file, not relative to `process.cwd()`

mischnic force-pushed the mischnic/backport-84155-85323 branch from 417eb2a to 61fbff8 Compare January 28, 2026 09:58

mischnic merged commit 84de13f into next-15-5 Jan 28, 2026
126 of 133 checks passed

mischnic deleted the mischnic/backport-84155-85323 branch January 28, 2026 10:45

github-actions bot added the locked label Feb 11, 2026

github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[backport] NFT tracing fixes #84155 and #85323#88124

[backport] NFT tracing fixes #84155 and #85323#88124
mischnic merged 2 commits intonext-15-5from
mischnic/backport-84155-85323

mischnic commented Jan 5, 2026

Uh oh!

nextjs-bot commented Jan 5, 2026

Uh oh!

codspeed-hq bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

nextjs-bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mischnic commented Jan 5, 2026

Uh oh!

nextjs-bot commented Jan 5, 2026

Uh oh!

codspeed-hq bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will degrade performance by 20.02%

Summary

Performance Changes

Footnotes

Uh oh!

nextjs-bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing test suites

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq bot commented Jan 5, 2026 •

edited

Loading

nextjs-bot commented Jan 28, 2026 •

edited

Loading