Skip to content

cna: fix typo#83121

Merged
ijjk merged 5 commits intovercel:canaryfrom
roottool:patch-3
Sep 8, 2025
Merged

cna: fix typo#83121
ijjk merged 5 commits intovercel:canaryfrom
roottool:patch-3

Conversation

@roottool
Copy link
Copy Markdown
Contributor

Summary

This PR fixes a typo in packages/create-next-app/templates/app-api/ts/gitignore. I fixed it from commiting to committing.

# env files (can opt-in for commiting if needed)

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Aug 27, 2025
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Aug 28, 2025

Allow CI Workflow Run

  • approve CI run for commit: 01189e0

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Sep 8, 2025

Failing test suites

Commit: d6b14c9 | About building and testing Next.js

pnpm test test/integration/build-indicator/test/index.test.js (turbopack)

  • Build Activity Indicator > Enabled - (app) > Shows build indicator when page is built from modifying (DD)
Expand output

● Build Activity Indicator › Enabled - (app) › Shows build indicator when page is built from modifying

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  102 |       const wasVisible = await browser.eval('window.showedBuilder')
  103 |
> 104 |       expect(wasVisible).toBe(true)
      |                          ^
  105 |       await fs.writeFile(pagePath, origContent, 'utf8')
  106 |       await browser.close()
  107 |     })

  at Object.toBe (integration/build-indicator/test/index.test.js:104:26)

@ijjk ijjk merged commit 7a43540 into vercel:canary Sep 8, 2025
62 of 142 checks passed
@roottool roottool deleted the patch-3 branch September 9, 2025 01:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants